Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Constructs now reuse the victim's mind instead of just moving their client #2146

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1157
Original PR: tgstation/tgstation#81665

About The Pull Request

This makes it so when someone becomes a construct, their mind is transferred, rather than just their ckey.

Why It's Good For The Game

It's the same soul after all. Plus, this prevents clogging up the roundend report.

Testing Evidence

2024-02-24 (1708802154) ~ dreamseeker
2024-02-24 (1708802162) ~ dreamseeker
2024-02-24 (1708802171) ~ dreamseeker

Changelog

🆑 Absolucy
qol: Constructs now reuse the victim's mind instead of just moving their client
/:cl:

…g their client (#1157)

* Constructs now reuse the victim's mind instead of just moving their client (#81665)

## About The Pull Request

This makes it so when someone becomes a construct, their _mind_ is
transferred, rather than just their ckey.

## Why It's Good For The Game

It's the same soul after all. Plus, this prevents clogging up the
roundend report.

## Testing Evidence

![2024-02-24 (1708802154) ~
dreamseeker](https://github.com/tgstation/tgstation/assets/65794972/5a33c1eb-55d4-4386-99ea-0c16f5efec3c)
![2024-02-24 (1708802162) ~
dreamseeker](https://github.com/tgstation/tgstation/assets/65794972/10429beb-4d54-4fb2-884b-42569802e0ee)
![2024-02-24 (1708802171) ~
dreamseeker](https://github.com/tgstation/tgstation/assets/65794972/967d99ac-d460-46a9-b7c9-f0c7c6c187d3)


## Changelog
:cl:
qol: Constructs now reuse the victim's mind instead of just moving their
client
/:cl:

* Constructs now reuse the victim's mind instead of just moving their client

---------

Co-authored-by: Lucy <[email protected]>
@Iajret Iajret merged commit acedd84 into master Feb 29, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1157 branch February 29, 2024 18:19
AnywayFarus added a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants