Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes paddy claw missing sanity checks / action checks / usage log #2144

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1151
Original PR: tgstation/tgstation#81596

About The Pull Request

Paddy mech claw didn't

  • Call action_checks
  • istype the right type
  • call parent (no signal, no log)

This fixes that.

Changelog

🆑 Melbert
fix: The Paddy's Claw should be properly unusable in situations which it should be properly unusable.
/:cl:

…ge log (#1151)

* Fixes paddy claw missing sanity checks / action checks / usage log (#81596)

## About The Pull Request

Paddy mech claw didn't
- Call `action_checks`
- istype the right type 
- call parent (no signal, no log) 

This fixes that. 

## Changelog

:cl: Melbert
fix: The Paddy's Claw should be properly unusable in situations which it
should be properly unusable.
/:cl:

* Fixes paddy claw missing sanity checks / action checks / usage log

---------

Co-authored-by: MrMelbert <[email protected]>
@Iajret Iajret merged commit 46575e5 into master Feb 29, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1151 branch February 29, 2024 18:18
AnywayFarus added a commit that referenced this pull request Feb 29, 2024
Iajret pushed a commit that referenced this pull request Apr 23, 2024
…s ListInputWindow which uses it" (#2144)

* Revert "Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it"

* Revert "Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it" (#82841)

Reverts tgstation/tgstation#82792

* Revert "Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it" (#82841)

Reverts tgstation/tgstation#82792

---------

Co-authored-by: Kyle Spier-Swenson <[email protected]>
Co-authored-by: Mal <[email protected]>
Iajret added a commit that referenced this pull request Apr 23, 2024
…s ListInputWindow which uses it" (#3039)

* [MIRROR] Revert "Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it" (#2144)

* Revert "Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it"

* Revert "Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it" (#82841)

Reverts tgstation/tgstation#82792

* Revert "Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it" (#82841)

Reverts tgstation/tgstation#82792

---------

Co-authored-by: Kyle Spier-Swenson <[email protected]>
Co-authored-by: Mal <[email protected]>

* Revert "Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it" (#82841)

Reverts tgstation/tgstation#82792

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Kyle Spier-Swenson <[email protected]>
Co-authored-by: Mal <[email protected]>
Co-authored-by: Iajret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants