Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes missing prefix, :g (changeling hivemind) to actually be indicated in the Say TGUI #2139

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1143
Original PR: tgstation/tgstation#81661

About The Pull Request

The Say menu didn't have any visual indications that cling hivemind was a usable prefix to communicate, this PR rectifies that.

Why It's Good For The Game

More visual indicators..... GOOD!

Changelog

🆑 Singul0
fix: The say TGUI would recognize :g (changeling hivemind) prefix. and give a visual indicator in it that you are talking in the right channel
/:cl:

…e indicated in the Say TGUI (#1143)

* Fixes missing prefix, :g (changeling hivemind) to actually be indicated in the Say TGUI (#81661)

## About The Pull Request
The Say menu didn't have any visual indications that cling hivemind was
a usable prefix to communicate, this PR rectifies that.
## Why It's Good For The Game
More visual indicators..... GOOD!
## Changelog
:cl:
fix: The say TGUI would recognize :g (changeling hivemind) prefix. and
give a visual indicator in it that you are talking in the right channel
/:cl:

* Fixes missing prefix, :g (changeling hivemind) to actually be indicated in the Say TGUI

---------

Co-authored-by: Singul0 <[email protected]>
@Iajret Iajret merged commit 4b4f899 into master Feb 28, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1143 branch February 28, 2024 11:43
AnywayFarus added a commit that referenced this pull request Feb 28, 2024
Iajret pushed a commit that referenced this pull request Apr 23, 2024
…putWindow which uses it (#2139)

* Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it (#82792)

## About The Pull Request

If we say something is a Modal it should actually be a Modal

## Why It's Good For The Game

You can now use this system in other windows if you want.
Fixed the misnomer.

---------

Co-authored-by: Jeremiah <[email protected]>

* Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it

---------

Co-authored-by: Zephyr <[email protected]>
Co-authored-by: Jeremiah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants