[MIRROR] Fixes cardboard cutout CI harrassment #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes cardboard cutout CI harrassment (#81627) ## About The Pull Request This has been coming up in almost every PR and I'm sick of it.  Fixes it for good. Also fixes an unrelated issue, where it was previously adding the `alternate_appearance` to the cutout object instead of the mob. Then when it tried to remove it, it was trying to remove it from the mob rather than the cutout object, causing it not actually be removed. <details><summary>Still works fine</summary>   </details> ## Why It's Good For The Game Bugfix ## Changelog :cl: fix: fixes cardboard cutouts not updating when held and using the crayon on them to change their appearance, and fixes the alt_appearance being added to the cutout instead of the mob holding it /:cl: --- EDIT: #81657 was merged before this and it introduces a new issue where the cardboard cutout does not update when you change it with a crayon while holding it. This should fix that, revised changelog. * Fixes cardboard cutout CI harrassment --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 26, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 23, 2024
Cargo ui refactor -> TS Co-authored-by: Jeremiah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1140
Original PR: tgstation/tgstation#81627
About The Pull Request
This has been coming up in almost every PR and I'm sick of it.
Fixes it for good. Also fixes an unrelated issue, where it was previously adding the
alternate_appearanceto the cutout object instead of the mob. Then when it tried to remove it, it was trying to remove it from the mob rather than the cutout object, causing it not actually be removed.Still works fine
Why It's Good For The Game
Bugfix
Changelog
🆑 vinylspiders
fix: fixes cardboard cutouts not updating when held and using the crayon on them to change their appearance, and fixes the alt_appearance being added to the cutout instead of the mob holding it
/:cl:
EDIT: #81657 was merged before this and it introduces a new issue where the cardboard cutout does not update when you change it with a crayon while holding it. This should fix that, revised changelog.