[MIRROR] Logs holochip credits worth zero or less credits and prevents them from spawning. #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s them from spawning. (#1139) * Logs holochip credits worth zero or less credits and prevents them from spawning. (#81605) * Logs holochip credits worth zero or less credits and prevents them from spawning. --------- Co-authored-by: ArcaneMusic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1139
Original PR: tgstation/tgstation#81605
About The Pull Request
This pull request will cause holochip/holocredits that spawn that have a value of 0 credits or less by any means to
stack_trace, log where they were spawned, and then proceed to delete itself in init in order to prevent situations where holochips worth nothing to not spawn.This also cleans up holochip spawning instances within the code in order to prevent any of those instances occurring pre-maturely, like with the luxury shuttle scanner gate and within the payment component when making change.
Lastly cleans up some variable names while I'm in the ballpark related to economy side things.
Why It's Good For The Game
Fixes #77969, or at the very least prevents as many situations where a null holochip is created without otherwise resulting in an error we can jump back to for future bug fixing. Additionally, pre-emptively cleans up a few situations in the code were we don't apply the amount ahead of time.
Changelog
🆑 ArcaneMusic
fix: Fixed instances where holochip/holocredits would spawn with a total of zero credits contained within.
/:cl: