Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] bodytypes to do with body shape and sprite handling have their own var #2130

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1125
Original PR: tgstation/tgstation#81590

About The Pull Request

Bodytypes like BODYTYPE_HUMANOID, BODYTYPE_MONKEY, etc that have to do with the shape of a human body and sprite handling, now have their own "bodyshape" var instead of being in bodytype along with stuff like BODYTYPE_ORGANIC, BODYTYPE_ROBOTIC; which have nothing to do with shapes and sprites

Why It's Good For The Game

the way these are used in the code is totally different to BODYTYPE_ROBOTIC, which determine whether you can heal a limb with medicine etc.

Changelog

🆑 13spacemen
refactor: Bodytypes to do with character sprite shape now have their own bodyshape var, all sprite handling is done with bodyshape and not bodytype anymore
/:cl:

…ir own var (#1125)

* bodytypes to do with body shape and sprite handling have their own var

* Refactors our modular files, painfully

---------

Co-authored-by: 13spacemen <[email protected]>
Co-authored-by: Mal <[email protected]>
@Iajret Iajret merged commit 09859ae into master Mar 1, 2024
23 checks passed
@Iajret Iajret deleted the upstream-mirror-1125 branch March 1, 2024 11:37
AnywayFarus added a commit that referenced this pull request Mar 1, 2024
Iajret pushed a commit that referenced this pull request Apr 22, 2024
* [NO GBP] Fixes runtime in advanced camera console (#82699)

## About The Pull Request
We only unset machine if we have a user who has logged in

## Changelog
:cl:
fix: Fixes runtime in advanced camera console when power is turned off
/:cl:

* [NO GBP] Fixes runtime in advanced camera console

---------

Co-authored-by: SyncIt21 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants