[MIRROR] Fix runtime when food processor handles items without reagents #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts (#1131) * Fix runtime when food processor handles items without reagents (#81646) ## About The Pull Request ### Alternate title: "Stop the popsicle stick maximizer." <details> <summary>The popsicle stick maximizer in question</summary>  </details> So when using the food processor to produce popsicle sticks from logs, it seemed to never actually delete the log, letting you create more and more and more and more and more and etc popsicle sticks. This seemed to be caused by the popsicles not actually having reagents to clear nor copy to, and thus it caused a runtime before it got the opportunity to delete the log. <details> <summary>Runtime</summary>  </details> Adding a check to make sure neither of these are null before proceeding to use them resolves this issue. ## Why It's Good For The Game Less runtimes, less popsicle stick maximizing. Fixes #81644. ## Changelog :cl: fix: Disabled the popsicle stick maximizer. (Producing popsicle sticks actually deletes the input logs.) /:cl: * Fix runtime when food processor handles items without reagents --------- Co-authored-by: _0Steven <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 26, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Add utf8 support for state laws button (#82789) ## About The Pull Request Adds UTF-8 support for state laws HTML page. Now it supports more than just English ## Why It's Good For The Game Support for other symbols, such as cyrillic  * Add utf8 support for state laws button --------- Co-authored-by: larentoun <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Add utf8 support for state laws button (#82789) ## About The Pull Request Adds UTF-8 support for state laws HTML page. Now it supports more than just English ## Why It's Good For The Game Support for other symbols, such as cyrillic  * Add utf8 support for state laws button --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: larentoun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1131
Original PR: tgstation/tgstation#81646
About The Pull Request
Alternate title: "Stop the popsicle stick maximizer."
The popsicle stick maximizer in question
So when using the food processor to produce popsicle sticks from logs, it seemed to never actually delete the log, letting you create more and more and more and more and more and etc popsicle sticks.
This seemed to be caused by the popsicles not actually having reagents to clear nor copy to, and thus it caused a runtime before it got the opportunity to delete the log.
Runtime
Adding a check to make sure neither of these are null before proceeding to use them resolves this issue.
Why It's Good For The Game
Less runtimes, less popsicle stick maximizing.
Fixes #81644.
Changelog
🆑 00-Steven
fix: Disabled the popsicle stick maximizer. (Producing popsicle sticks actually deletes the input logs.)
/:cl: