[MIRROR] [NON-MODULAR] Disable CPR For Synth Heatsink #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable CPR for synths * Cleaning up extra conditional * Swap inversion operator for isnull Co-authored-by: Bloop <[email protected]> * Add conditional for checking synth lungs, undo earlier changes * Change chat message to balloon alert * Change Nova edit comment * Relocate heatsink conditional to more sensible line * Update code/modules/mob/living/carbon/human/human.dm --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 26, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 22, 2024
Revert "Borg movement now has sounds" Co-authored-by: Zephyr <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 22, 2024
Revert "Borg movement now has sounds" Co-authored-by: NovaBot <[email protected]> Co-authored-by: Zephyr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#870
About The Pull Request
This is a tiny edit which disables CPR if the performer's lungs organ is a
/obj/item/organ/internal/lungs/synth(Heatsink).How This Contributes To The Nova Sector Roleplay Experience
Due to the way synthetic characters are constructed on Nova Sector, many players including myself consider their ability to administer CPR to be missing from the game. Many synthetic characters have cybernetic lungs instead of a heatsink, and so the boon to them is immediately obvious.
Proof of Testing
I have tested this change extensively to ensure that it works as expected.
Screenshots/Videos
Changelog
🆑 A.C.M.O.
qol: Disabled CPR for synthetic species with a heatsink. Choosing cybernetic lungs will allow CPR.
/:cl: