[MIRROR] Fixes issues and improves millstones, ant farms and seed meshes #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a few issues with millstones, improves feedback * Makes ant farms easier to fill with food, stop you when no longer needed, gives all sand back when destroyed * Makes seed meshes only take 2 seconds to sift through sand and increases chance of finding seed to 50% * Addresses review comments in order to improve the ant farm code
AnywayFarus
added a commit
that referenced
this pull request
Feb 26, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 21, 2024
* [NO GBP] HPLC can purify inverted chems (#82727) ## About The Pull Request - Fixes #82725 Inverted chems are now coloured green and classified as clean (like before my general maintenance PR) which means they can be purified again. Only chems that are too impure to use & have an inverted chem value are coloured red in the UI and not when they are just of the inverted type ## Changelog :cl: fix: HPLC can purify inverted chems and are now coloured green(clean) in the UI /:cl: * [NO GBP] HPLC can purify inverted chems --------- Co-authored-by: SyncIt21 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 22, 2024
* [NO GBP] HPLC can purify inverted chems (#82727) ## About The Pull Request - Fixes #82725 Inverted chems are now coloured green and classified as clean (like before my general maintenance PR) which means they can be purified again. Only chems that are too impure to use & have an inverted chem value are coloured red in the UI and not when they are just of the inverted type ## Changelog :cl: fix: HPLC can purify inverted chems and are now coloured green(clean) in the UI /:cl: * [NO GBP] HPLC can purify inverted chems --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1070
About The Pull Request
Millstones no longer take damage when you insert something that has force (i.e. tower-cap logs) into them. Improves the feedback given by the millstone using balloon alerts when you insert items, and when you finish grinding.
Ant farms now drop the full amount of sand required to build them, when you try to build them in an invalid location. They now no longer accept food in them when ants have already appeared (because why would they?), and items inserted via plant bag usage is now two times faster (1/s -> 2/s).
Seed meshes now take 2 seconds to process 5 pieces of sand/ash instead of 5, and have a 50% chance of producing seeds, up from 30%. It's mainly to reduce the tedium of trying to obtain seeds from them, because they're otherwise a very niche and disappointing was to get seeds currently, with very low odds of ever really getting what you're after. This makes them a little more reliable and actually worth investing time into.
How This Contributes To The Nova Sector Roleplay Experience
Fixing bugs is good. More feedback is good. Reducing tedium is also good.
Proof of Testing
Screenshots/Videos
Look, it didn't get damaged from a tower-cap log!
I got 20 sand from building an ant farm in an invalid location.
Changelog
🆑 GoldenAlpharex
fix: Millstones no longer take damage when produce that can do damage (like tower-cap logs) get inserted in them.
qol: Millstones now give better feedback when items are inserted and when grinding is done.
fix: Ant farms now drop all of the 20 pieces of sand that are required to make them, when built in an invalid location.
qol: Ant farms no longer accept food when ants have appeared, as it already does nothing once ants have arrived.
qol: Inserting food in an ant farm from a plant bag is now twice as fast!
qol: Seed meshes now only take 2 seconds to process 5 sand/ash, and have a 50% chance to produce a seed, up from 30%.
/:cl: