[MIRROR] Can't Thatch This | Adds Thatch, coming from drying grass, to allow for players to make thatch floors + Bonus fixes to primitive storage structures #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or players to make thatch floors + Bonus fixes to primitive storage structures (#1067) * Adds thatch as a result of drying grass, usable to make thatch patches * Fixes a few bugs with what drops from primitive storage structures + decapitalizes their names * weapon -> item_to_check * Addresses more review comments * Fixes it being able to move things you shouldn't be able to move with shelves
AnywayFarus
added a commit
that referenced
this pull request
Feb 26, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 22, 2024
…2112) * Fixes dropdown displaytext not working for numeric values * Update dropdowns.tsx --------- Co-authored-by: Bloop <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 22, 2024
…2112) (#3010) * Fixes dropdown displaytext not working for numeric values * Update dropdowns.tsx --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1067
About The Pull Request
Thatch has cool floor sprites, I figured I'd let people use it elsewhere than where it's been mapped in only.
You get thatch from drying grass in the drying rack, and then you use it just like grass in order to make thatch tiles. They're basically fancier, reskinned grass tiles, so they /will/ currently drop grass when scooped up with a shovel, but I didn't feel like making some overrides to prevent this was really worth the headache.
All of the sprites were simple recolors of existing grass sprites, using the palette from the thatch roofs themselves, done by yours truly.
As a bonus, I've also de-capitalized a lot of the primitive storage structures (produce bins, produce display, seed shelf), and fixed that some of them dropped clay when deconstructed, even though they didn't require clay when crafted. Finally, I also allowed
/obj/item/grownin the produce bins, mainly so that we can store basically everything you can get from growing plants, in one structure. The produce display is still there, of course, but I figured it was a lot more convenient to have this available for both, mainly because otherwise there's specific flowers that can't be put into the produce bin, which feels counter-intuitive.How This Contributes To The Nova Sector Roleplay Experience
More accessibility to floor options that already exist for mappers is good!
Fixes and QoL stuff is also good for my sanity.
Proof of Testing
Screenshots/Videos
Changelog
🆑 GoldenAlpharex
qol: Grass can now be dried into thatch, rendering thatch floors accessible to the crew, and not just a tool only for mappers.
fix: Storage barrels and wooden shelves no longer drop clay upon being deconstructed.
spellcheck: Decapitalized the various primitive storage structures that were wrongfully capitalized.
/:cl: