[MIRROR] Fix some attack effects not playing / Fix apply_damage returning innacurate values
#2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urning innacurate values (#1114) * Fix some attack effects not playing / Fix `apply_damage` returning innacurate values * Update damage_procs.dm --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1114
Original PR: tgstation/tgstation#81635
About The Pull Request
Seems to have been a merge skew between #78657 and #79207 .
When my PR was written they returned the damage being done, when their PR was written they returned the change in health?
So apply damage was returning
-10when it should've been returning10for some cases.Changelog
🆑 Melbert
fix: Cyborgs spark and spit out oil when smacked again. Among other things.
/:cl: