[MIRROR] Adds loot blacklist, creates a maintenance spawner with decals blacklisted #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls blacklisted (#1109) * Adds loot blacklist, creates a maintenance spawner with decals blacklisted (#81611) * Adds loot blacklist, creates a maintenance spawner with decals blacklisted * Why is this here --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 25, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 21, 2024
* Adds `ALLOW_RESTING` to a bunch of items (#82761) ## About The Pull Request Allows you to alt-click a bunch of items while resting. Fixes #82788 ## Why It's Good For The Game Some of these, such as storage, are bugfixes. You shouldn't need to be standing up to configure a spray can, or change the direction of your bedsheet Others are just sensible changes. ## Changelog :cl: Melbert fix: You can open bags with alt click while resting again qol: Many items which previously required you to stand to alt-click now don't, such as bedsheets and spray cans /:cl: * Adds `ALLOW_RESTING` to a bunch of items --------- Co-authored-by: MrMelbert <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 21, 2024
* Adds `ALLOW_RESTING` to a bunch of items (#82761) ## About The Pull Request Allows you to alt-click a bunch of items while resting. Fixes #82788 ## Why It's Good For The Game Some of these, such as storage, are bugfixes. You shouldn't need to be standing up to configure a spray can, or change the direction of your bedsheet Others are just sensible changes. ## Changelog :cl: Melbert fix: You can open bags with alt click while resting again qol: Many items which previously required you to stand to alt-click now don't, such as bedsheets and spray cans /:cl: * Adds `ALLOW_RESTING` to a bunch of items --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1109
Original PR: tgstation/tgstation#81611
About The Pull Request
Is anyone else sick of this? Because I am. tgstation/tgstation#81520 missed one. But I think being able to spawn randomized loot over a chasm should be a valid thing to do in general so here is an alternate way of doing it.
Maintenance spawners can creates ashes, as was happening on this chasm turf, which would cause
NeverShouldHaveComeHere()to fail. Cue the rng based CI failures.This PR adds a blacklist feature to spawners, allowing custom blacklist behavior to be defined by overriding the new
can_spawn()proc.Also adds back the spawner that was removed by tgstation/tgstation#81520, replacing it with the new decal-free variety.
Why It's Good For The Game
Less CI failures.
NeverShouldHaveComeHere()is a mess to keep adding exceptions to for things like this so having a way to blacklist certain types from spawning in the first place allows for greater flexibility when it comes to mapping.Changelog
🆑 vinylspiders
fix: fixes spurious CI failure in museum
code: adds a blacklist feature to spawners
/:cl: