Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes arcade cabinets being un-hittable #2099

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1105
Original PR: tgstation/tgstation#81620

About The Pull Request

What if we put all of our item based interactions in the same function that attacks are handled? Great idea, I'm sure no one will ever forget to call parent

Fixes that.

Also cleans up ticket code.

Also renames the base type so mappers stop mapping it in.

Changelog

🆑 Melbert
fix: You can now take our your anger upon arcade cabinets upon losing (they can be hit again)
/:cl:

* Fixes arcade cabinets being un-hittable (#81620)

## About The Pull Request

What if we put all of our item based interactions in the same function
that attacks are handled? Great idea, I'm sure no one will ever forget
to call parent

Fixes that. 

Also cleans up ticket code. 

Also renames the base type so mappers stop mapping it in. 

## Changelog

:cl: Melbert
fix: You can now take our your anger upon arcade cabinets upon losing
(they can be hit again)
/:cl:

* Fixes arcade cabinets being un-hittable

---------

Co-authored-by: MrMelbert <[email protected]>
@Iajret Iajret merged commit 00604bd into master Feb 24, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1105 branch February 24, 2024 22:41
AnywayFarus added a commit that referenced this pull request Feb 24, 2024
Iajret pushed a commit that referenced this pull request Apr 20, 2024
* Admin Forced Mob Rename and Preference Update (#82715)

* Admin Forced Mob Rename and Preference Update

---------

Co-authored-by: Zephyr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants