[MIRROR] Fix polls #2087
Merged
[MIRROR] Fix polls #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update new_player.dm * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Update modular_nova/modules/title_screen/code/new_player.dm --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 22, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 20, 2024
* Adds Retain volume flag on the ants reaction * Update others.dm * Update others.dm --------- Co-authored-by: Pink <[email protected]> Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1080
About The Pull Request
The hrefs to handle viewpoll and viewpollref were apparently being checked in new_player/Topic(href, href_list[]) which was getting overwritten with our modular one. I think. I'm just copying #1061 except with the advantage of having a local database running to test stuff.
Closes #1061.
How This Contributes To The Nova Sector Roleplay Experience
Polls were broken.
Proof of Testing
Screenshots/Videos
Changelog
🆑 Thlumyn
fix: fixed polls
/:cl: