Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] BBQ ribs can be grilled & adds qdel checks for grills #2042

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1030
Original PR: tgstation/tgstation#81536

About The Pull Request

  • Fixes #81511. BBQ ribs can be grilled again and takes anywhere between 30 to 40 seconds to get proper grilled ribs or turn into a mouldy mess. 20 seconds would only yield lightly grilled ribs and that's not good.
  • Grill checks if the item got deleted to avoid runtimes. Also cook time is set based on the individual items type & not a constant of 20 seconds

Changelog

🆑 SyncIt21
fix: Grill checks if the item got deleted to avoid runtimes. Also cook time is set based on the individual items type & not a constant of 20 seconds
fix: BBQ ribs can be grilled on a grill but now takes anywhere between 30 to 40 seconds to get proper smoked ribs and not lightly smoked ribs or turn into a mouldy mess on a girddle. Delicious.
/:cl:

* BBQ ribs can be grilled & adds qdel checks for grills (#81536)

## About The Pull Request
- Fixes #81511. BBQ ribs can be grilled again and takes anywhere between
30 to 40 seconds to get proper grilled ribs or turn into a mouldy mess.
20 seconds would only yield lightly grilled ribs and that's not good.
- Grill checks if the item got deleted to avoid runtimes. Also cook time
is set based on the individual items type & not a constant of 20 seconds

## Changelog
:cl:
fix: Grill checks if the item got deleted to avoid runtimes. Also cook
time is set based on the individual items type & not a constant of 20
seconds
fix: BBQ ribs can be grilled on a grill but now takes anywhere between
30 to 40 seconds to get proper smoked ribs and not lightly smoked ribs
or turn into a mouldy mess on a girddle. Delicious.
/:cl:

---------

Co-authored-by: jimmyl <[email protected]>

* BBQ ribs can be grilled & adds qdel checks for grills

---------

Co-authored-by: SyncIt21 <[email protected]>
Co-authored-by: jimmyl <[email protected]>
@Iajret Iajret merged commit 62f04ab into master Feb 19, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1030 branch February 20, 2024 09:25
Iajret pushed a commit that referenced this pull request May 8, 2024
…n gen cleanup I guess (#2042)

* Fix height settings double-applying offsets / some human icon gen cleanup I guess

* Modular updates

* Update human_update_icons.dm

---------

Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: Mal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants