Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Cardboard cutouts are now tactical. #2032

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1013
Original PR: tgstation/tgstation#81245

About The Pull Request

Basically, this means players holding cardboard cutouts will now assume their appearance, just like for potted plants. Good for pranking.

I've had to tweak the tactical component and the waddling element a bit to get them to work as intended while dealing with the multiple sources of the waddling element.

Why It's Good For The Game

Changelog

🆑 Ghommie
add: Players holding cardboard cutouts will now assume their appearance, just like for potted plants.
/:cl:

* Cardboard cutouts are now tactical. (#81245)

## About The Pull Request
Basically, this means players holding cardboard cutouts will now assume
their appearance, just like for potted plants. Good for pranking.

I've had to tweak the tactical component and the waddling element a bit
to get them to work as intended while dealing with the multiple sources
of the waddling element.

## Why It's Good For The Game
![](https://media1.tenor.com/m/X1GimXmuByYAAAAd/tom-cruise-doorbell.gif)

## Changelog

:cl:
add: Players holding cardboard cutouts will now assume their appearance,
just like for potted plants.
/:cl:

* Cardboard cutouts are now tactical.

---------

Co-authored-by: Ghom <[email protected]>
@Iajret Iajret merged commit 6b15b69 into master Feb 19, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1013 branch February 19, 2024 17:53
AnywayFarus added a commit that referenced this pull request Feb 19, 2024
Iajret pushed a commit that referenced this pull request Apr 19, 2024
* Switch big moarter to item_interactions

clean up some balloon alerts

* decon fixes, move to atom_deconstruction

* millstone decon fix

* No free pots.

* oven decon

* Show our stack recipes in crafting menu

* shouldn't be calling parent here

* machines use on_decon

* missed a no_decon

* Smithable soup pots

* mortar mixing

* stop if full

* /closet handles this actually

* redundant flags

* whoopsie

* wait, that's not right

* mortar reagent transfers

* revert this whole ass file

* just put this back i guess

* no rack parts

* moves some checks around, better checks

* better mortar sanity

* this hurts me as much as it hurts you

* we still need attackby :(

* this is too verbose

* Some forge fixes too

* smithing decon

* Novification ™️

* Move clay to the modular file too

* Might as well grab these too
ReezeBL pushed a commit that referenced this pull request Apr 19, 2024
* Switch big moarter to item_interactions

clean up some balloon alerts

* decon fixes, move to atom_deconstruction

* millstone decon fix

* No free pots.

* oven decon

* Show our stack recipes in crafting menu

* shouldn't be calling parent here

* machines use on_decon

* missed a no_decon

* Smithable soup pots

* mortar mixing

* stop if full

* /closet handles this actually

* redundant flags

* whoopsie

* wait, that's not right

* mortar reagent transfers

* revert this whole ass file

* just put this back i guess

* no rack parts

* moves some checks around, better checks

* better mortar sanity

* this hurts me as much as it hurts you

* we still need attackby :(

* this is too verbose

* Some forge fixes too

* smithing decon

* Novification ™️

* Move clay to the modular file too

* Might as well grab these too

Co-authored-by: FlufflesTheDog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants