[MIRROR] Fixes some items produced by using plants not inheriting reagent purity #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gent purity [MDB IGNORE] (#24486) * Fixes some items produced by using plants not inheriting reagent purity (#79123) ## About The Pull Request In #78322 I removed the reagent purity initialize argument from grown items, thinking it was only used by butter. It was actually used in two other places which I missed, in which I have implemented the same functionality. Rather than passing the desired purity on creation we instead just set the purity of contents reagents after initialising the atom. This broadly replicates what the edible component was doing, as these items only get reagents from being edible. ## Changelog :cl: fix: Meatwheat Clumps, Bungo Pits, and Eggplant Eggs should once again inherit reagent purity from the grown item which produces them. /:cl: * Fixes some items produced by using plants not inheriting reagent purity --------- Co-authored-by: Jacquerel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24486
Original PR: tgstation/tgstation#79123
About The Pull Request
In #78322 I removed the reagent purity initialize argument from grown items, thinking it was only used by butter. It was actually used in two other places which I missed, in which I have implemented the same functionality.
Rather than passing the desired purity on creation we instead just set the purity of contents reagents after initialising the atom. This broadly replicates what the edible component was doing, as these items only get reagents from being edible.
Changelog
🆑 Jacquerel
fix: Meatwheat Clumps, Bungo Pits, and Eggplant Eggs should once again inherit reagent purity from the grown item which produces them.
/:cl: