[MIRROR] Adds support for different achievement dmis #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for different achievement dmis (#81471) ## About The Pull Request I am back to pushing my code improvements upstream, sorry in advance. As the title says, this adds support for achievement icons to be in different dmi files than the default, pretty much the exact same way that Language icons (for chat assets) do. ## Why It's Good For The Game It is one of the few things in game (the only other thing i can think of that does this rn is barsigns) that cannot have their icon changed when trying to make a subtype, this is very limiting and very annoying, especially since dmi conflicts are one of the worst types to deal with, this would make my life a lot easier. ## Changelog No player-facing changes. * Adds support for different achievement dmis --------- Co-authored-by: John Willard <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 22, 2024
* wip * yeah there we are * Apply suggestions from code review Co-authored-by: Tom <[email protected]> * ok * wew * wew mb * ci fix * meow * Update modular_nova/modules/implants/code/augments_arms.dm Co-authored-by: Tom <[email protected]> * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Update modular_nova/modules/implants/code/augments_arms.dm --------- Co-authored-by: SomeRandomOwl <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#978
Original PR: tgstation/tgstation#81471
About The Pull Request
I am back to pushing my code improvements upstream, sorry in advance.
As the title says, this adds support for achievement icons to be in different dmi files than the default, pretty much the exact same way that Language icons (for chat assets) do.
Why It's Good For The Game
It is one of the few things in game (the only other thing i can think of that does this rn is barsigns) that cannot have their icon changed when trying to make a subtype, this is very limiting and very annoying, especially since dmi conflicts are one of the worst types to deal with, this would make my life a lot easier.
Changelog
No player-facing changes.