[MIRROR] Fixes valentine love again, for real this time, "why did no one report this" edition #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one report this" edition (#964) * Fixes valentine love again, for real this time, "why did no one report this" edition (#81470) ## About The Pull Request Basic one-person huds now default to having no AA flags set, rather than `AA_TARGET_SEE_APPEARANCE` set I thought it would be fine to let basic huds just use default hud flags without realizing the default flags were very self-defeating for this. Also also kinda dumb. Why does it default to letting the target see the hud? Whatever I guess. This fixes Valentines seeing love hearts on themselves in addition to their companion I'm surprised no one reported this. ## Changelog :cl: Melbert fix: Valentines no longer see themselves covered in hearts. They only see their Valentine covered in hearts. /:cl: * Fixes valentine love again, for real this time, "why did no one report this" edition --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 15, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 14, 2024
) * [READY] MASSIVE CRAYON BUFF (GAME-CHANGING) (MUST MERGE) (#82638) ## About The Pull Request You can now type up to 4 letters on a tile at once, one for each corner of the tile, an ability lost when max interactions was added.  ## Why It's Good For The Game Currently if you're typing on the floor with a crayon, you either spend a million years going letter by letter, or do the alternative of typing every second letter to write on 3 tiles at once, and repeat, which is stupid that we even have to do that. ## Changelog :cl: qol: Crayons can now draw up to 4 letters at a time per tile. /:cl: * [READY] MASSIVE CRAYON BUFF (GAME-CHANGING) (MUST MERGE) --------- Co-authored-by: John Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#964
Original PR: tgstation/tgstation#81470
About The Pull Request
Basic one-person huds now default to having no AA flags set, rather than
AA_TARGET_SEE_APPEARANCEsetI thought it would be fine to let basic huds just use default hud flags without realizing the default flags were very self-defeating for this. Also also kinda dumb. Why does it default to letting the target see the hud? Whatever I guess.
This fixes Valentines seeing love hearts on themselves in addition to their companion
I'm surprised no one reported this.
Changelog
🆑 Melbert
fix: Valentines no longer see themselves covered in hearts. They only see their Valentine covered in hearts.
/:cl: