[MIRROR] Moves inter-round caches to cache/. Deletes tmp/ between rounds. Keeps tts from killing servers. #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nds. Keeps tts from killing servers. (#954) * Moves inter-round caches to cache/. Deletes tmp/ between rounds. Keeps tts from killing servers. (#81433) * Moves inter-round caches to cache/. Deletes tmp/ between rounds. Keeps tts from killing servers. --------- Co-authored-by: Kyle Spier-Swenson <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 14, 2024
… stacktrace (#1978) * Adds the proc we're overriding to RegisterSignals's override stacktrace (#82641) ## About The Pull Request We get it for quite literally free, no reason not to dump it. I always find myself checking in the debugger, which says something about what'll happen when I don't have that again. * Adds the proc we're overriding to RegisterSignals's override stacktrace --------- Co-authored-by: LemonInTheDark <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 14, 2024
… stacktrace (#1978) (#2871) * Adds the proc we're overriding to RegisterSignals's override stacktrace (#82641) ## About The Pull Request We get it for quite literally free, no reason not to dump it. I always find myself checking in the debugger, which says something about what'll happen when I don't have that again. * Adds the proc we're overriding to RegisterSignals's override stacktrace --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: LemonInTheDark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#954
Original PR: tgstation/tgstation#81433
Fun fact, the only reason tts isn't killing our hard drive is because of auto-update. every time auto-update breaks, the hard drive fills up.
I skimmed all uses of
tmpand found what i think is the only thing that assumes these will hang around between rounds.I was gonna make this also handle deleting cache/ if tgs wasn't around by hashing the dmb and rsc files and checking this hash, but that will need this feature request ID:2912240 unless i want to work around it for something we don't even need in prod.
I decided to have
tmp/be deleted in both shutdown and startup so that clean shutdowns leave things... well.... clean, while still deleting in startup so that unclean shutdowns still cleans things.