[MIRROR] Operand Swap for QuirksPage.tsx #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Operand Swap for QuirksPage.tsx (#81438) ## About The Pull Request The changes included in this PR were requested by maintainers of [Nova Sector](https://github.com/NovaSector/NovaSector). - Changed the input operand of `getValueClass`, replacing the `value` number with the full `quirk` object. - Renamed `getValueClass` to `getColorValueClass`. ## Why It's Good For The Game A downstream repository has requested that I make this change, so they can easily maintain their own changes to it. The change should allow them to add more heading colors for quirks on the Character Preferences page. This change is purely semantic, and there are no visible changes to the game, * Operand Swap for QuirksPage.tsx --------- Co-authored-by: Dani Glore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#952
Original PR: tgstation/tgstation#81438
About The Pull Request
The changes included in this PR were requested by maintainers of Nova Sector.
getValueClass, replacing thevaluenumber with the fullquirkobject.getValueClasstogetColorValueClass.Why It's Good For The Game
A downstream repository has requested that I make this change, so they can easily maintain their own changes to it.
The change should allow them to add more heading colors for quirks on the Character Preferences page.
This change is purely semantic, and there are no visible changes to the game,