[MIRROR] [MODULAR] Down By The River: Telepathy improvements & telepathic quirk #1930
Conversation
#603) * Refactor telepathy power to point-target, add reply functionality & telepathic quirk * Fix CI issues * Let silicons pick telepathic quirk as well * Handle the fact that silicons don't have DNA (or mutations) in telepathic quirk * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Use proper procs for runechat creation * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Remove blocked return (unneeded) * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Reorder last-target checks to actually occur only on secondary * Improve autoformatting and improve ghost observer output * Minor formatting improvements to telepathy observer line * Allow telepaths to discern who's sending them telepathic messages * Attempt logging fix --------- Co-authored-by: Bloop <[email protected]>
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.0.1 to 10.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@10.0.1...10.3.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Original PR: NovaSector/NovaSector#603
About The Pull Request
Telepathy has kind of sucked for a while in terms of actually using it as a dedicated communication method. This PR includes a full rework of telepathy into a point-targeting ability (goodbye list targeting) with a right-click override for sending quick messages to the last target you spoke with, and an emote reply (*treply) so you can keybind replies to something that doesn't involve map clicks at all.
In addition, telepathy now shows a runechat message both above your head (the sender) and above the recipient's head, allowing telepathy chat to be read entirely via runechat. It comes from the recipient's head for them because the messages are in their mind.
And of course, the whole thing is autopunctuated. :)
There's now also a 0pt Telepathic quirk that either activates telepathy if it's in your roundstart genome or adds it as an unremovable, no cost mutation if it isn't. Espers rejoice!
How This Contributes To The Nova Sector Roleplay Experience
This makes playing roundstart psychics/psionicists and a whole slew of other concepts possible, and it also makes telepathy SIGNIFICANTLY less ass to actually use. Mind conversations for everyone!
Proof of Testing
Screenshots/Videos
Showcasing usability/point targeting improvements (both left click & right click) & emote reply:
dreamseeker_iELu0oEifz.mp4
Messaging from sender's perspective:
Messaging from recipient's perspective:
Changelog
🆑 yooriss
qol: The telepathy genetics mutation has had significant usability improvements: it is now point-targeting based, and right-clicking the power allows for quick resending to the same target, a feature mirrored by the new *treply emote. Telepathy now also shows runechat messages.
add: The Telepathic quirk has been added, allowing characters to start with an unremovable (or activated) telepathy mutation.
/:cl: