Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Add: 2 Quirks Configs #1779

Merged
merged 5 commits into from
Feb 28, 2024
Merged

[MIRROR] Add: 2 Quirks Configs #1779

merged 5 commits into from
Feb 28, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#549
Original PR: tgstation/tgstation#81033

About The Pull Request

This PR adds two new config options for quirks:

  • Flag DISABLE_QUIRK_POINTS
    • When enabled, disables quirk points balancing.
    • When enabled, players can select positive quirks without first selecting negative ones.
    • When enabled, the quirk points balance visually hides itself on the Quirks page.
  • Number MAX_POSITIVE_QUIRKS
    • Limits the maximum quantity of positive quirks which players can select using the Character Preferences page.
    • I ported this from the old MAX_QUIRKS define.
    • When set to 0, players won't be able to select any positive quirks, and they won't appear on the Quirks page.
    • When set to -1, players will be able to select any quantity of positive quirks.
    • When commented-out or undefined, the default is 6.
    • When set to 0 or -1, the positive quirk balance visually hides itself on the Quirks page.

Why It's Good For The Game

There is some downstream repositories asking for the quirks system to be configurable. Additionally, I always find myself tweaking these values on my own private servers and I thought it would be nice to share my edits. Usually I was simply commenting-out sections of this code in order to get the same result, so it helps to have an official way to disable quirk points.

Changelog

🆑 A.C.M.O.
config: Added two new config flags for quirks, DISABLE_QUIRK_POINTS and MAX_POSITIVE_QUIRKS.
/:cl:

* Add: 2 Quirks Configs

* Conflicts

* Hotfix for Upstream Merge 81033 (#564)

* Add boolean quirk_points_enabled to LimbsPage, auto-hide quirk points balance on Augments page if false.

* Add boolean quirk_points_enabled to LimbsPage preferences middleware

* Nothing, Just forcing CI to run (hopefully)

---------

Co-authored-by: SomeRandomOwl <[email protected]>

* Silly Wabbit

* Removes Gifted

---------

Co-authored-by: Dani Glore <[email protected]>
Co-authored-by: Mal <[email protected]>
Co-authored-by: SomeRandomOwl <[email protected]>
Co-authored-by: Zergspower <[email protected]>
@Steals-The-PRs Steals-The-PRs added Configs Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror labels Jan 31, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Feb 15, 2024
@github-actions github-actions bot closed this Feb 23, 2024
@Iajret Iajret reopened this Feb 27, 2024
@Iajret Iajret enabled auto-merge (squash) February 28, 2024 18:52
@Iajret Iajret merged commit 2e3426d into master Feb 28, 2024
22 of 23 checks passed
AnywayFarus added a commit that referenced this pull request Feb 28, 2024
@Iajret Iajret deleted the upstream-mirror-549 branch February 29, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Configs Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота Stale TG Mirror
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants