[MIRROR] Changes one wall in syndicate lavaland base to stop it from being nuked by a chemist #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being nuked by a chemist (#699) * Changes one wall in syndicate lavaland base to stop it from being nuked by a chemist (#81176) ## About The Pull Request changes one explosive wall in the chemistry room to the corner of the room in order to avoid chemists nuking the entire base by simply yeeting a potas water grenade into the experimentation chamber  ## Why It's Good For The Game makes it easier to not accidently fuck over 4 people by trying to do your job as a bioweapon scientist ## Changelog :cl: fix: makes the experiment chamber in syndicate lavaland base no longer explode when testing grenades /:cl: * Changes one wall in syndicate lavaland base to stop it from being nuked by a chemist --------- Co-authored-by: K4rlox <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 6, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 2, 2024
…1768) * Give Error Messages On Subsystem Initialization Failure CI (#82139) ## About The Pull Request Noticed during #82138 Basically, the unit test that makes sure that all of the subsystems that had to initialize properly initialized is good with the Notice annotation, but it had a flaw - it didn't tell you _why_ the subsystem failed to initialize:  Basically this PR just adds a variable, `initialization_failure_message` (i have it on good authority that variables that don't get changed from their compile time variable don't take up extra memory), and we just append the failure message to this notice should it occur so all of the information is available in one spot, rather than have the coder dig through the CI Run Log to figure out what the specific error was should it occur on something that isn't SSlua. also small cute code cleanup :3 * Give Error Messages On Subsystem Initialization Failure CI --------- Co-authored-by: san7890 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 3, 2024
…1768) (#2699) * Give Error Messages On Subsystem Initialization Failure CI (#82139) ## About The Pull Request Noticed during #82138 Basically, the unit test that makes sure that all of the subsystems that had to initialize properly initialized is good with the Notice annotation, but it had a flaw - it didn't tell you _why_ the subsystem failed to initialize:  Basically this PR just adds a variable, `initialization_failure_message` (i have it on good authority that variables that don't get changed from their compile time variable don't take up extra memory), and we just append the failure message to this notice should it occur so all of the information is available in one spot, rather than have the coder dig through the CI Run Log to figure out what the specific error was should it occur on something that isn't SSlua. also small cute code cleanup :3 * Give Error Messages On Subsystem Initialization Failure CI --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: san7890 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#699
Original PR: tgstation/tgstation#81176
About The Pull Request
changes one explosive wall in the chemistry room to the corner of the room in order to avoid chemists nuking the entire base by simply yeeting a potas water grenade into the experimentation chamber
Why It's Good For The Game
makes it easier to not accidently fuck over 4 people by trying to do your job as a bioweapon scientist
Changelog
🆑 K4rlox
fix: makes the experiment chamber in syndicate lavaland base no longer explode when testing grenades
/:cl: