[MIRROR] Fixes ore vent descriptions stacking, fixes potential exploits with ore vent scanning #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with ore vent scanning (#690) * Fixes ore vent descriptions stacking, fixes potential exploits with ore vent scanning (#81174) ## About The Pull Request - Scanning ore vents did a do_after to do the actual scan, but if the do_after failed, it didn't cancel the scan proc, and rewarded you points anyways. So you could just keep cancelling the scan for free points? - Also there was nothing preventing someone from stacking scans on the same vent - Also, when generating the ore description, always override existing descriptions. Given `generate_description` can be called multiple times, prevents it from stacking on itself. ## Changelog :cl: Melbert fix: Fixed ore vent descriptions looking weird sometimes fix: Fixed being able to scan an ore vent multiple times at once fix: Fixed gaining scan points from scannning an ore vent without finishing the scan /:cl: * Fixes ore vent descriptions stacking, fixes potential exploits with ore vent scanning --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jan 31, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Improved lathe error message (#82260) ## About The Pull Request Improves the auto/protolathe low charge error message. Instead of simply saying low power, it will tell you how long until it has enough charge to print.  ## Why It's Good For The Game Less mashing the lathe over and over with no idea how much APC charge it needs to start printing again ## Changelog :cl: LT3 code: APCs can now calculate time-to-charge qol: Overloaded lathes will now tell you the wait time until they're ready to print again /:cl: --------- Co-authored-by: san7890 <[email protected]> * Improved lathe error message --------- Co-authored-by: lessthanthree <[email protected]> Co-authored-by: san7890 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Improved lathe error message (#82260) ## About The Pull Request Improves the auto/protolathe low charge error message. Instead of simply saying low power, it will tell you how long until it has enough charge to print.  ## Why It's Good For The Game Less mashing the lathe over and over with no idea how much APC charge it needs to start printing again ## Changelog :cl: LT3 code: APCs can now calculate time-to-charge qol: Overloaded lathes will now tell you the wait time until they're ready to print again /:cl: --------- * Improved lathe error message --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: lessthanthree <[email protected]> Co-authored-by: san7890 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#690
Original PR: tgstation/tgstation#81174
About The Pull Request
Scanning ore vents did a do_after to do the actual scan, but if the do_after failed, it didn't cancel the scan proc, and rewarded you points anyways. So you could just keep cancelling the scan for free points?
Also there was nothing preventing someone from stacking scans on the same vent
Also, when generating the ore description, always override existing descriptions. Given
generate_descriptioncan be called multiple times, prevents it from stacking on itself.Changelog
🆑 Melbert
fix: Fixed ore vent descriptions looking weird sometimes
fix: Fixed being able to scan an ore vent multiple times at once
fix: Fixed gaining scan points from scannning an ore vent without finishing the scan
/:cl: