[MIRROR] Cult pylons won't convert floorless floors #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cult pylons won't convert floorless floors (#81171) ## About The Pull Request Cult pylons read from our existing list of "turfs which don't count as floor despite being open turfs" instead of having its own one, which did not include openspace turfs. This prevents it from "papering over" things like stairwells and sealing people inside their base.  ## Why It's Good For The Game It's not supposed to do that, and fixing it this way is futureproof to a greater degree. ## Changelog :cl: fix: Cult pylons will no longer cover up "open space" (or water) with cult floors /:cl: * Cult pylons won't convert floorless floors --------- Co-authored-by: Jacquerel <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jan 31, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 2, 2024
…357 revolver; In this house our gun explodes from excessive pressure (#1762) * Detective revolver no longer can be turned into a flawless .357 revolver; In this house our gun explodes from excessive pressure (#82331) ## About The Pull Request Fixes tgstation/tgstation#82324 Also cleans up a lot of the code around the issue itself. ## Why It's Good For The Game You should not be able to modify this revolver while it is loaded whatsoever. I don't know when exactly this broke, but time has clearly not been kind to the feature. I think it was actually impossible to reach the self explosion on modifying the gun? The return I added probably prevented it outright. I guess that was broken the entire time. Honestly, I feel like that's going to be a maintainability issue to keep it working, so maybe we just do away with what we never had. Maybe it was for the very, very unlikely possibility that you could theoretically load in a bullet DURING the do_after? I think I was just sleep deprived. Like right now. ## Changelog :cl: fix: Detective revolvers can no longer exist in a quantum state of both being chambered in .38 and .357, without risk of misfire. Detectives, cowboy enthusiasts and reckless federal agents across the Spinward Sector mourn the loss. /:cl: * Detective revolver no longer can be turned into a flawless .357 revolver; In this house our gun explodes from excessive pressure --------- Co-authored-by: necromanceranne <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 3, 2024
…357 revolver; In this house our gun explodes from excessive pressure (#1762) (#2704) * Detective revolver no longer can be turned into a flawless .357 revolver; In this house our gun explodes from excessive pressure (#82331) ## About The Pull Request Fixes tgstation/tgstation#82324 Also cleans up a lot of the code around the issue itself. ## Why It's Good For The Game You should not be able to modify this revolver while it is loaded whatsoever. I don't know when exactly this broke, but time has clearly not been kind to the feature. I think it was actually impossible to reach the self explosion on modifying the gun? The return I added probably prevented it outright. I guess that was broken the entire time. Honestly, I feel like that's going to be a maintainability issue to keep it working, so maybe we just do away with what we never had. Maybe it was for the very, very unlikely possibility that you could theoretically load in a bullet DURING the do_after? I think I was just sleep deprived. Like right now. ## Changelog :cl: fix: Detective revolvers can no longer exist in a quantum state of both being chambered in .38 and .357, without risk of misfire. Detectives, cowboy enthusiasts and reckless federal agents across the Spinward Sector mourn the loss. /:cl: * Detective revolver no longer can be turned into a flawless .357 revolver; In this house our gun explodes from excessive pressure --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: necromanceranne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#692
Original PR: tgstation/tgstation#81171
About The Pull Request
Cult pylons read from our existing list of "turfs which don't count as floor despite being open turfs" instead of having its own one, which did not include openspace turfs.
This prevents it from "papering over" things like stairwells and sealing people inside their base.
Why It's Good For The Game
It's not supposed to do that, and fixing it this way is futureproof to a greater degree.
Changelog
🆑 Jacquerel
fix: Cult pylons will no longer cover up "open space" (or water) with cult floors
/:cl: