[MIRROR] Fix "All Within Theoretical Limits" not being granted when delamination variants change #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed when delamination variants change (#693) * [NO GBP] Fix "All Within Theoretical Limits" not being granted when delamination variants change (#81168) ## About The Pull Request I made a change in #80324 that prevents delamination variants from updating after the countdown is reached, however AWTL wouldn't obey this because the countdown proc sleeps while the crystal comes back from the countdown stage, so the `delamination_strategy` var will have changed. I removed 3 dead lines of code (because delam variants never change during the countdown). Fixes #79528 this time hopefully ## Why It's Good For The Game work, damn it ## Changelog :cl: fix: All Within Theoretical Limits should properly unlock now when the crystal comes back from the countdown. /:cl: * [NO GBP] Fix "All Within Theoretical Limits" not being granted when delamination variants change --------- Co-authored-by: distributivgesetz <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jan 31, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 2, 2024
* [NO GBP] Fixes prosthetic limb quirk preferences (#82354) ## About The Pull Request Accidentally broke it during my latest quirk PR, oops! ## Changelog :cl: fix: Fixed Prosthetic limb quirk preferences /:cl: * [NO GBP] Fixes prosthetic limb quirk preferences --------- Co-authored-by: DATAxPUNGED <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 3, 2024
) * [NO GBP] Fixes prosthetic limb quirk preferences (#82354) ## About The Pull Request Accidentally broke it during my latest quirk PR, oops! ## Changelog :cl: fix: Fixed Prosthetic limb quirk preferences /:cl: * [NO GBP] Fixes prosthetic limb quirk preferences --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: DATAxPUNGED <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#693
Original PR: tgstation/tgstation#81168
About The Pull Request
I made a change in #80324 that prevents delamination variants from updating after the countdown is reached, however AWTL wouldn't obey this because the countdown proc sleeps while the crystal comes back from the countdown stage, so the
delamination_strategyvar will have changed. I removed 3 dead lines of code (because delam variants never change during the countdown).Fixes #79528 this time hopefully
Why It's Good For The Game
work, damn it
Changelog
🆑 distributivgesetz
fix: All Within Theoretical Limits should properly unlock now when the crystal comes back from the countdown.
/:cl: