Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Clear kitten begging target after begging. #1729

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#646
Original PR: tgstation/tgstation#81124

About The Pull Request

Alternative title: "Remove kitten omniscience."

If you were to ever have the hubris of entering a kitten's line of sight while holding a food they like, like a dead mouse, they would start pointing and meowing at you. It's their food, after all. You should give it to them.
However, if you were to drop the item, they would continue pointing.
If you were to leave the area, they would continue pointing.
Even if you were to run, to hide, to break down and cry.
They would continue pointing. Meowing
Forever.
And Ever.
You can't run. You can't hide. You can't fool them.
That ever sweet scent stays with you, lingering. It marks you.
Wherever you are, whenever you are, the wretched beasts will know.
Even in death your corpse will be theirs to torment.
For you, oh marked one, this is now a fact of life.
And you better bring your masters their food.

Putting aside how funny the kitten-based triangulation device is, this feels like an oversight.
/.../beacon_for_food/finish_action(...) even tries to clear the begging target from the blackboard, but /.../beacon_for_food/perform(...) never actually passes in the key.

Why It's Good For The Game

Kittens no longer beg at you forever wherever you are, even after dropping the food they were begging for.
image
Like forever, wherever.
image
image

Changelog

🆑 00-Steven
fix: Removed kitten omniscience. (They stop pointing at you now.)
/:cl:

* Clear kitten begging target after begging. (#81124)

## About The Pull Request

### Alternative title: "Remove kitten omniscience."

>If you were to ever have the hubris of entering a kitten's line of
sight while holding a food they like, like a dead mouse, they would
start pointing and meowing at you. It's their food, after all. You
should give it to them.
However, if you were to drop the item, they would continue pointing.
If you were to leave the area, they would continue pointing.
Even if you were to run, to hide, to break down and cry.
They would continue pointing. Meowing
Forever.
And Ever.
You can't run. You can't hide. You can't fool them.
That ever sweet scent stays with you, lingering. It marks you.
Wherever you are, whenever you are, the wretched beasts will know.
Even in death your corpse will be theirs to torment.
For you, oh marked one, this is now a fact of life.
_And you better bring your masters their food._

Putting aside how funny the kitten-based triangulation device is, this
feels like an oversight.
`/.../beacon_for_food/finish_action(...)` even tries to clear the
begging target from the blackboard, but
`/.../beacon_for_food/perform(...)` never actually passes in the key.
## Why It's Good For The Game

Kittens no longer beg at you forever wherever you are, even after
dropping the food they were begging for.

![image](https://github.com/tgstation/tgstation/assets/42909981/146d9f93-57e6-4408-aba3-6c693add0841)
Like forever, wherever.

![image](https://github.com/tgstation/tgstation/assets/42909981/d62dbd12-15d1-4bc7-9696-d3b50f1b91d8)

![image](https://github.com/tgstation/tgstation/assets/42909981/46da6905-b29c-43a4-b2f1-bdbd27d0e96d)
## Changelog
:cl:
fix: Removed kitten omniscience. (They stop pointing at you now.)
/:cl:

* Clear kitten begging target after begging.

---------

Co-authored-by: _0Steven <[email protected]>
@Iajret Iajret merged commit d21a184 into master Jan 29, 2024
23 checks passed
AnywayFarus added a commit that referenced this pull request Jan 29, 2024
@Iajret Iajret deleted the upstream-mirror-646 branch January 29, 2024 21:11
Iajret pushed a commit that referenced this pull request Mar 30, 2024
…1729)

* Makes simple bodycam component `COMPONENT_DUPE_SELECTIVE` (#82310)

## About The Pull Request

The thought only just occurred to me people may want to throw multiple
bodycams with different networks on them onto one mob, and it would be
trivially easy to support, so here.

I used `COMPONENT_DUPE_SELECTIVE` rather than `COMPONENT_DUPE_ALLOWED`
so people can avoid adding two of the same camera (network) to one mob.

* Makes simple bodycam component `COMPONENT_DUPE_SELECTIVE`

---------

Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants