[MIRROR] Updates the "Slim" belt reskin and code cleanup of no longer used "peacekeeper" belts #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acekeeper" belts (#552) * slim -> upstream basic * remove overridden override (this is physically inaccessible code) * removes peacekeeper belt (no longer used item) * peacekeeper webbing is now just a reskin of TG webbing (until TG resprites it and I can remove this thing) * removes unused icons too * override woes and a CI fix * okay fine you win shitcode you win * fine. FINE. you WIN. i regret making you, you evil item. * ok yea that ones on me * oh my godddddd * Forgive me. Forgive me.
AnywayFarus
added a commit
that referenced
this pull request
Jan 31, 2024
Iajret
pushed a commit
that referenced
this pull request
Mar 30, 2024
* Your heart stops beating when you die now. (#82305) ## About The Pull Request Your heart stops beating when you die now. ## Why It's Good For The Game Did you know spacemen hearts kept beating for like 8 minutes despite being dead until the organ failure finally stopped it? This is stupid from a consistency and realism standpoint. ## Changelog :cl: balance: Your heart stops beating when you die now. /:cl: * Your heart stops beating when you die now. --------- Co-authored-by: Iamgoofball <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#552
About The Pull Request
Saw the screenshot of the current belts included a very outdated sprite. Found out it's not even linking to TG's file so now its doing that.
While here I did a few other things:
How This Contributes To The Nova Sector Roleplay Experience
Sprite that isnt years out of date, other related cleanup
Proof of Testing
Screenshots/Videos
Reskin, onmob, and obj icons all work as expectedPeacekeeper webbing still exists
So does the armadyne belt because they still exist inlore for now
Changelog
🆑 OrionTheFox
del: Removed unused "Peacekeeper Belt" and put the remaining "Peacekeeper Webbing" in-line with TG Sec Webbing
image: updated the icon used for the "Slim" variant of sec belts (now called "Basic")
/:cl: