Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Re-adds some cat things that got lost in their refactor as basic pets. #1718

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#633
Original PR: tgstation/tgstation#81108

About The Pull Request

When cats were turned into basic mobs it seems a few things were lost in translation, being footsteps and cytology cell swabbing. All this pr does is basically re-add the lines that did such, though slightly barely differently due to now being basic pets.

Why It's Good For The Game

Lets you get feliform cells again. Also cats not having footstep sounds feels eerie.

Changelog

🆑 00-Steven
fix: Cats can be swabbed for feliform cells again.
sound: Cats have had their mastery of silent walking revoked, and have their pitter-pattering footsteps back again.
/:cl:

…asic pets. (#633)

* Re-adds some cat things that got lost in their refactor as basic pets. (#81108)

## About The Pull Request

When cats were turned into basic mobs it seems a few things were lost in
translation, being footsteps and cytology cell swabbing. All this pr
does is basically re-add the lines that did such, though _slightly
barely_ differently due to now being basic pets.
## Why It's Good For The Game

Lets you get feliform cells again. Also cats not having footstep sounds
feels eerie.
## Changelog
:cl:
fix: Cats can be swabbed for feliform cells again. 
sound: Cats have had their mastery of silent walking revoked, and have
their pitter-pattering footsteps back again.
/:cl:

* Re-adds some cat things that got lost in their refactor as basic pets.

---------

Co-authored-by: _0Steven <[email protected]>
@Iajret Iajret merged commit 437b2db into master Jan 29, 2024
23 checks passed
AnywayFarus added a commit that referenced this pull request Jan 29, 2024
@Iajret Iajret deleted the upstream-mirror-633 branch January 29, 2024 21:27
Iajret pushed a commit that referenced this pull request Mar 30, 2024
* Bumps `dependencies.sh` to 515.1633 Stable (#82138)

## About The Pull Request

Two reasons for this.

1. It's the stable branch, so let's move it up. This PR will detect any
issues that we might have with the latest 515.1633 as far as the
codebase is concerned (the servers have been running 1633 for at least a
week now).
2. ~~I'm fucking sick of seeing the Lua Scripting Notice in CI even
though it was fixed a few days ago in #82074
(5624d9452413641b4c6d4b886cb116481186b8ac)

`![image](https://github.com/tgstation/tgstation/assets/34697715/0cc889c9-25d0-48cb-a0d1-304738acd8cc)`~~

* Bumps `dependencies.sh` to 515.1633 Stable

---------

Co-authored-by: san7890 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants