Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Ports the longer, gloomier bangs from Skyrat #1716

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#609

About The Pull Request

Ports the new longer, gloomier bangs that have been added to Skyrat with #26038 for use in NovaSector as well.

How This Contributes To The Nova Sector Roleplay Experience

As one of the people who made the original request, back before the servers split even, it would be nice to be able to use the hair across both servers....

Proof of Testing

The code compiled, the game booted, nothing was broken, and the game worked correctly, hairstyle is even next to the similar ones in the menu making it easy enough to find.

Screenshot from the loaded game with the option selected to proof.

gloomyhair

Changelog

🆑 cherdaq
add: Added a longer gloomier hair option.
/:cl:

* Update hair.dm

* Add files via upload
@Iajret Iajret merged commit d48477f into master Jan 26, 2024
23 checks passed
@Iajret Iajret deleted the upstream-mirror-609 branch January 26, 2024 23:05
AnywayFarus added a commit that referenced this pull request Jan 26, 2024
Iajret pushed a commit that referenced this pull request Mar 30, 2024
* Fix double-encode with AI holocall messages (#82290)

## About The Pull Request

Fixed yet another double-encode, the bane of my existence

fixes tgstation/tgstation#68274

## Why It's Good For The Game

Because\&​\#​44\;​ it\&​\#​39\;​s like\&​\#​44\;​ whenever your talking
about how something\&​\#​39\;​s blowing up or how\&​\#​39\;​s the
weather on shitbox\&​\#​44\;​ or quoting \&​\#​34\;​Hey\&​\#​44\;​ John
McTide slept with your mom\&​\#​34\;​\&​\#​44\;​ it makes it SO much
harder to read\&​\#​46\;​

## Changelog
:cl:
fix: Fixed double-encoded messages with AI holocalls.
/:cl:

* Fix double-encode with AI holocall messages

---------

Co-authored-by: Lucy <[email protected]>
ReezeBL pushed a commit that referenced this pull request Mar 30, 2024
* Fix double-encode with AI holocall messages (#82290)

## About The Pull Request

Fixed yet another double-encode, the bane of my existence

fixes tgstation/tgstation#68274

## Why It's Good For The Game

Because\&​\#​44\;​ it\&​\#​39\;​s like\&​\#​44\;​ whenever your talking
about how something\&​\#​39\;​s blowing up or how\&​\#​39\;​s the
weather on shitbox\&​\#​44\;​ or quoting \&​\#​34\;​Hey\&​\#​44\;​ John
McTide slept with your mom\&​\#​34\;​\&​\#​44\;​ it makes it SO much
harder to read\&​\#​46\;​

## Changelog
:cl:
fix: Fixed double-encoded messages with AI holocalls.
/:cl:

* Fix double-encode with AI holocall messages

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Lucy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants