[MIRROR] Newspapers now use TGUI #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Newspapers now use TGUI (#80991) ## About The Pull Request Newspapers work as a static newscaster that is not affected by things like D-notices and changing wanted issues after its been printed. It doesn't store comments or get any updates after its been printed. You can also scribble on the paper to leave notes on a specific page, which is a feature I have never seen in my life but it is still here I guess. Minor things I've added: - Sound effect when printing the newspaper in the first place - 2 second do-after when scribbling just for some player feedback and consistency - Balloon alerts - Context tips for scribbling and burning I also fixed an issue with wanted issues on newscasters when there isn't an image. As a minor note, I replaced the instances of ``content`` in Buttons I saw in newscaster's UI because it's marked as deprecated. Too lazy to take a video sorry    ## Why It's Good For The Game Fixes an issue with newscasters and makes newspapers use a nice TGUI that feels more responsive than before. Helps further https://hackmd.io/XLt5MoRvRxuhFbwtk4VAUA even more. ## Changelog :cl: refactor: Newspapers now use TGUI. fix: Fixed the newscaster's wanted section showing a non-existent photo. /:cl: * Newspapers now use TGUI --------- Co-authored-by: John Willard <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jan 26, 2024
Iajret
pushed a commit
that referenced
this pull request
Mar 29, 2024
* Fixes ghosts not being able to check records * Update human.dm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#614
Original PR: tgstation/tgstation#80991
About The Pull Request
Newspapers work as a static newscaster that is not affected by things like D-notices and changing wanted issues after its been printed. It doesn't store comments or get any updates after its been printed.
You can also scribble on the paper to leave notes on a specific page, which is a feature I have never seen in my life but it is still here I guess.
Minor things I've added:
I also fixed an issue with wanted issues on newscasters when there isn't an image.
As a minor note, I replaced the instances of
contentin Buttons I saw in newscaster's UI because it's marked as deprecated.Too lazy to take a video sorry
Why It's Good For The Game
Fixes an issue with newscasters and makes newspapers use a nice TGUI that feels more responsive than before.
Helps further https://hackmd.io/XLt5MoRvRxuhFbwtk4VAUA even more.
Changelog
🆑 JohnFulpWillard
refactor: Newspapers now use TGUI.
fix: Fixed the newscaster's wanted section showing a non-existent photo.
/:cl: