[MIRROR] Fixes features not updating when changing character slots #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Fixes features not updating when changing character slots (#81018) ## About The Pull Request What it says on the tin. The entire bottom half of the prefs was not updating on switching character slots. ~~We need to use the old hook here because it needs the key to differentiate the active slot.~~ edit: useEffect can work in its stead here as mothblocks pointed out 👍 ## Why It's Good For The Game Bugfix for a kind of serious issue for downstreams, not so much here because there aren't really any text fields being used as features. ## Changelog :cl: fix: fixes features not updating when changing character slots /:cl: * Fixes features not updating when changing character slots --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jan 24, 2024
Iajret
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Readability Pass to Advanced Medical Tools (#82225) ## About The Pull Request Update the sprites of the advanced surgical toolset, giving them distinct colors and updating their lighting to reduce shades and increase visual readability at normal resolutions.    ## Why It's Good For The Game Currently, the advanced surgical toolset over-relies on the tooltip to communicate item state quickly and accurately. This PR adds both color differentials, and enhances the shape of the existing tools to help a player tell them apart quickly and accurately. Additionally, it assists in defining the general shape of the item with cleaned up shading to decrease noisy patterns in the sprite. ## Changelog :cl: image: Updated the Advanced Surgical Tool's sprites code: Updated the Advanced Surgical Tool's light code /:cl: * Readability Pass to Advanced Medical Tools --------- Co-authored-by: Alexios <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Readability Pass to Advanced Medical Tools (#82225) ## About The Pull Request Update the sprites of the advanced surgical toolset, giving them distinct colors and updating their lighting to reduce shades and increase visual readability at normal resolutions.    ## Why It's Good For The Game Currently, the advanced surgical toolset over-relies on the tooltip to communicate item state quickly and accurately. This PR adds both color differentials, and enhances the shape of the existing tools to help a player tell them apart quickly and accurately. Additionally, it assists in defining the general shape of the item with cleaned up shading to decrease noisy patterns in the sprite. ## Changelog :cl: image: Updated the Advanced Surgical Tool's sprites code: Updated the Advanced Surgical Tool's light code /:cl: * Readability Pass to Advanced Medical Tools --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Alexios <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#568
Original PR: tgstation/tgstation#81018
About The Pull Request
What it says on the tin. The entire bottom half of the prefs was not updating on switching character slots.
We need to use the old hook here because it needs the key to differentiate the active slot.edit: useEffect can work in its stead here as mothblocks pointed out 👍
Why It's Good For The Game
Bugfix for a kind of serious issue for downstreams, not so much here because there aren't really any text fields being used as features.
Changelog
🆑 vinylspiders
fix: fixes features not updating when changing character slots
/:cl: