[MIRROR] Fixes a bunch of config changes that hadn't been made properly #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bunch of config changes that hadn't been ran through me first
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
AnywayFarus
added a commit
that referenced
this pull request
Feb 28, 2024
Iajret
pushed a commit
that referenced
this pull request
Mar 17, 2024
* Fix tgui dev server on Windows (#82032) ## About The Pull Request Fixes starting the tgui dev server on Windows machines. Currently on Windows when starting the tgui dev server, it will be unable to find the Byond cache at any of the predefined paths it searches, and resort to using the registry even if one of the predefined paths should successfully locate it. Then, it will fail to find the tmp# folder inside that cache folder even if it exists. The reason is that on Windows, the glob package requires forward slashes when you call its methods such as sync(), as documented in the glob module's documentation: >Note Glob patterns should always use / as a path separator, even on Windows systems, as \ is used to escape glob characters. If you wish to use \ as a path separator instead of using it as an escape character on Windows platforms, you may set windowsPathsNoEscape:true in the options. In this mode, special glob characters cannot be escaped, making it impossible to match a literal * ? and so on in filenames. The function being used to assemble the path, node's path.resolve(), uses backslashes if you call it on a Windows platform. It does not accept any arguments to alter this, nor are there any delimter-conversion functions in the path package. There is an alternative to change the delimiter, forcing POSIX-style path.resolve() by calling path.posix.resolve(), however this removes the drive letter and does not work as a valid path on Windows. For example: What we need to pass to globPkg.sync(): `C:/Users/SomeName/Documents/Byond/cache` What path.resolve() returns: `C:\Users\SomeName\Documents\Byond\cache` What path.posix.resolve() returns: `/Users/SomeName/Documents/Byond/cache` Unfortunately there is not a method in the node path module to return what we need. Instead, we use the workaround provided in glob's documentation and add the windowsPathsNoEscape option. This COULD have a negative effect when searching for * and ? literals, however a search of resolveGlob() callers shows that none of them do this. * and ? in all callers is intended to be a wildcard, not a literal, so this won't have any impact on anything. ## Why It's Good For The Game Helps development efforts for developers using Windows. * Fix tgui dev server on Windows --------- Co-authored-by: Aronai Sieyes <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Fix tgui dev server on Windows (#82032) ## About The Pull Request Fixes starting the tgui dev server on Windows machines. Currently on Windows when starting the tgui dev server, it will be unable to find the Byond cache at any of the predefined paths it searches, and resort to using the registry even if one of the predefined paths should successfully locate it. Then, it will fail to find the tmp# folder inside that cache folder even if it exists. The reason is that on Windows, the glob package requires forward slashes when you call its methods such as sync(), as documented in the glob module's documentation: >Note Glob patterns should always use / as a path separator, even on Windows systems, as \ is used to escape glob characters. If you wish to use \ as a path separator instead of using it as an escape character on Windows platforms, you may set windowsPathsNoEscape:true in the options. In this mode, special glob characters cannot be escaped, making it impossible to match a literal * ? and so on in filenames. The function being used to assemble the path, node's path.resolve(), uses backslashes if you call it on a Windows platform. It does not accept any arguments to alter this, nor are there any delimter-conversion functions in the path package. There is an alternative to change the delimiter, forcing POSIX-style path.resolve() by calling path.posix.resolve(), however this removes the drive letter and does not work as a valid path on Windows. For example: What we need to pass to globPkg.sync(): `C:/Users/SomeName/Documents/Byond/cache` What path.resolve() returns: `C:\Users\SomeName\Documents\Byond\cache` What path.posix.resolve() returns: `/Users/SomeName/Documents/Byond/cache` Unfortunately there is not a method in the node path module to return what we need. Instead, we use the workaround provided in glob's documentation and add the windowsPathsNoEscape option. This COULD have a negative effect when searching for * and ? literals, however a search of resolveGlob() callers shows that none of them do this. * and ? in all callers is intended to be a wildcard, not a literal, so this won't have any impact on anything. ## Why It's Good For The Game Helps development efforts for developers using Windows. * Fix tgui dev server on Windows --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Aronai Sieyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#351
About The Pull Request
Config repathing needs to be ran through server administrators, otherwise they won't go into effect. This wasn't noticed instantly, because it wasn't actually properly done, leaving behind a bunch of broken links to various configs, which is why, having not been updated yet, most of the configs were working just fine.
If you are running a private server as a fork of NovaSector, you likely WILL have to rename the config folder manually. Just rename the
config/skyratdirectory asconfig/novainstead.How This Contributes To The Nova Sector Roleplay Experience
Interactions should be working again.
Changelog
🆑 GoldenAlpharex
config: Config migration to /nova instead of /skyrat has been properly completed.
/:cl: