[TG Mirror] Fix APC cell removal runtime #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix APC cell removal runtime (#79077) ## About The Pull Request Someone implemented `Exited` but didn't remove this code, it's not necessary and all it does is runtime now. * Fix APC cell removal runtime --------- Co-authored-by: MrMelbert <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Dec 28, 2023
* [NO GBP] Some reaction & chamber fixes (#80600) ## About The Pull Request - Fixes #80596 The UI opens when you remove/add a beaker to it - Fixes #80597 Calls `handle_reactions()` per step and updates UI thus reporting changes more often - Fixes tgstation/tgstation#80597 (comment). For instant reactions such as plastic we want to call `handle_reactions()` wherever possible (in this case whenever new reagent is added per equilibrium step) so that we can maximise product formed and start new reactions whenever possible - Fixes #80632 Same explanation as above since it now triggers all reactions more often ## Changelog :cl: fix: reaction chamber open its UI when inserting/removing beakers from it fix: reaction chamber triggers new reactions & updates UI more often during heating fix: instant and normal reactions now get triggered more often so for e.g. more plastic sheets from polymer reactions or more reactions occur when there are multiple reagents present /:cl: * [NO GBP] Some reaction & chamber fixes --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24427
Original PR: tgstation/tgstation#79077
About The Pull Request
Someone implemented
Exitedbut didn't remove this code, it's not necessary and all it does is runtime now.