[TG Mirror] Birdshot ordnance QoL #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Birdshot ordnance QoL (#79056) ## About The Pull Request Fixes #79003 I've added a couple of useful tools to Birdshot's ordnance lab - a second RPD, and two holofan projectors.  I also removed one (1) cable from under the reinforced window by ordnance's front door. I didn't touch the other electrified windows in the science wing. ## Why It's Good For The Game The extra RPD lets two people comfortably work in ordnance, like they can on most maps, and the holofan projectors allow changes to be made to the burn or freeze chambers without disaster. Most other maps have these things available, so it seems reasonable to add them here. As pointed out in #79003, a quick toxins moment is all it takes for the modified window to explode, and for the pressure to slam an unfortunate spaceman into an electrified grille until they die. This feels excessive to me, and the other ordnance windows aren't electrified - so I took the cable out. ## Changelog :cl: qol: Birdshot ordnance is now equipped with a second RPD and two holofan projectors. qol: Ordnance mishaps on Birdshot are significantly less likely to slam you into an electrified window until you die. /:cl: * Birdshot ordnance QoL --------- Co-authored-by: lizardqueenlexi <[email protected]>
Steals-The-PRs
added a commit
that referenced
this pull request
Oct 19, 2023
Iajret
pushed a commit
that referenced
this pull request
Dec 28, 2023
* Makes immerse use weakrefs (#80594) ## About The Pull Request Immerse was causing harddels due to it having references to mobs. Makes it use weakrefs for mobs instead. ## Why It's Good For The Game Immerse would cause harddels if a mob was deleted while it was in it's list. It could probably also happen if a turf was deleted too, but doing that here would be much harder. no CL since nothing playerfacing * Makes immerse use weakrefs --------- Co-authored-by: Arturlang <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24418
Original PR: tgstation/tgstation#79056
About The Pull Request
Fixes #79003
I've added a couple of useful tools to Birdshot's ordnance lab - a second RPD, and two holofan projectors.
I also removed one (1) cable from under the reinforced window by ordnance's front door. I didn't touch the other electrified windows in the science wing.
Why It's Good For The Game
The extra RPD lets two people comfortably work in ordnance, like they can on most maps, and the holofan projectors allow changes to be made to the burn or freeze chambers without disaster. Most other maps have these things available, so it seems reasonable to add them here.
As pointed out in #79003, a quick toxins moment is all it takes for the modified window to explode, and for the pressure to slam an unfortunate spaceman into an electrified grille until they die. This feels excessive to me, and the other ordnance windows aren't electrified - so I took the cable out.
Changelog
🆑 lizardqueenlexi
qol: Birdshot ordnance is now equipped with a second RPD and two holofan projectors.
qol: Ordnance mishaps on Birdshot are significantly less likely to slam you into an electrified window until you die.
/:cl: