[MIRROR] Reverts Canister Wiring (#80265) #1355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reverts Canister Wiring (#80265) (#80607) Reverts #80265 It's a cool idea, but the ability to toggle valves/control pressure make this just a ttv but without the access issues we tie to that. Eats into that space way too much. Removing those but not the rest results in disappointment, so I'm just full removing this. I am keeping the code quality changes, screentips, that sort of thing tho. That bit goes hard. Also, refactored a few procs slightly to make them easier to read. Early returns, sane loops, etc. Closes #80604 Cheap remote mass producible maxcaps are a bad idea actually Sorry I didn't catch this in review, been resting for the week :cl: del: Removes the wires from canisters. It's a cool idea, but cheap controlled maxcaps are bad actually /:cl: * Reverts Canister Wiring (#80265) --------- Co-authored-by: LemonInTheDark <[email protected]>
Steals-The-PRs
added
Mirroring conflict
Iajret
pushed a commit
that referenced
this pull request
Mar 9, 2024
* Makes wheat and meatwheat wearable (#81874) ## About The Pull Request Makes it so you can wear wheat and meatwheat in your mask slot, so you can truly live out your dreams of being a farmer on a space station. Draft while I sort out some issues Wheat on the left, meatwheat on the right  ## Why It's Good For The Game The fact this wasn't already possible is, frankly, a crime. ## Changelog :cl: add: Wheat and meatwheat can now be worn in the mask slot. Farmers rejoice! /:cl: * Makes wheat and meatwheat wearable --------- Co-authored-by: Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25875
Original PR: tgstation/tgstation#80607
About The Pull Request
Reverts #80265
It's a cool idea, but the ability to toggle valves/control pressure make this just a ttv but without the access issues we tie to that.
Eats into that space way too much.
Removing those but not the rest results in disappointment, so I'm just full removing this.
I am keeping the code quality changes, screentips, that sort of thing tho. That bit goes hard.
Also, refactored a few procs slightly to make them easier to read. Early returns, sane loops, etc.
Why It's Good For The Game
Closes #80604
Cheap remote mass producible maxcaps are a bad idea actually
Sorry I didn't catch this in review, been resting for the week
Changelog
🆑 LemonInTheDark
del: Removes the wires from canisters. It's a cool idea, but cheap controlled maxcaps are bad actually
/:cl: