Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Combine roundstart intercept and security level announcements #1234

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25759
Original PR: tgstation/tgstation#80475

About The Pull Request

At roundstart when the intercept report is sent, two announcements are created at the same time. It's loud and overlaps. This combines them into a single announcement.

Before:

image

After:

image

Why It's Good For The Game

Two Centcom or any other announcements playing at the same time (especially with two different sound files) can be annoying and the sounds distort each other.

Changelog

🆑 LT3
qol: Roundstart intercept report and security level announcements are combined into a single announcement
/:cl:

…s [MDB IGNORE] (#25759)

* Combine roundstart intercept and security level announcements (#80475)

## About The Pull Request

At roundstart when the intercept report is sent, two announcements are
created at the same time. It's loud and overlaps. This combines them
into a single announcement.

Before:

![image](https://github.com/tgstation/tgstation/assets/83487515/024e783a-65d9-4c28-8850-f114b1f020ad)

After:

![image](https://github.com/tgstation/tgstation/assets/83487515/7272f82f-23b4-4e90-99a2-1b590c7d56cf)

## Why It's Good For The Game

Two Centcom or any other announcements playing at the same time
(especially with two different sound files) can be annoying and the
sounds distort each other.

## Changelog

:cl: LT3
qol: Roundstart intercept report and security level announcements are
combined into a single announcement
/:cl:

* Combine roundstart intercept and security level announcements

---------

Co-authored-by: lessthanthree <[email protected]>
@ReezeBL ReezeBL merged commit bd40f85 into master Dec 21, 2023
23 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-25759 branch December 21, 2023 07:08
AnywayFarus added a commit that referenced this pull request Dec 21, 2023
Iajret pushed a commit that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants