Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Updates eslint + sorts imports #1210

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25722
Original PR: tgstation/tgstation#80430

About The Pull Request

General maintenance for eslint + adds an autofix for import sorting

If you're a reviewer/downstream, don't worry s'much about the file diff, these are automated changes. To port this is pretty simple:

  • cd tgui
  • Update other packages (optional)
  • yarn add eslint-plugin-simple-import-sort
  • Add linter rules: eslintrc.yml guide && file format rules to eslintignore
  • yarn eslint packages --fix

Done!

Why It's Good For The Game

Dev exp ++

Changelog

N/A nothing player facing

* Updates eslint + sorts imports

* Update yarn.lock

* Merge conflicts

* Run prettier on everything

* Update CharacterPreferenceWindow.tsx

* ts to tsx, run prettier on these neglected files

---------

Co-authored-by: Jeremiah <[email protected]>
Co-authored-by: Giz <[email protected]>
@ReezeBL ReezeBL merged commit fb30b04 into master Dec 20, 2023
23 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-25722 branch December 20, 2023 06:48
Iajret pushed a commit that referenced this pull request Feb 29, 2024
…takes .223. (Shush this is the same bullet) (#1210)

* Fixes the M-90GL saying that it takes 5.56 when it actually takes .223. (Shush this is the same bullet) (#81716)

* Fixes the M-90GL saying that it takes 5.56 when it actually takes .223. (Shush this is the same bullet)

---------

Co-authored-by: necromanceranne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants