[MIRROR] Resprites SpacePol Uniforms (And accessories) #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#25703) * Resprites SpacePol Uniforms (And accessories) (#80317) * Resprites SpacePol Uniforms (And accessories) * Digi refit by Orion --------- Co-authored-by: OrionTheFox <[email protected]> Co-authored-by: Giz <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Dec 20, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Fixes bows not loosening their strings once fired (#81724) ## About The Pull Request So, there's this one place that could have just called `clear_chambered` because it does the exact same operations, but didn't. Here's `gun/ballistic/proc/clear_chambered()`: https://github.com/tgstation/tgstation/blob/ce04e2b7ee279e025bd53e87296e7dfd70b9474a/code/modules/projectiles/guns/ballistic.dm#L285-L288 and here's `gun/ballistic/bow/clear_chambered()`, which is responsible for setting `drawn` to false: https://github.com/tgstation/tgstation/blob/ce04e2b7ee279e025bd53e87296e7dfd70b9474a/code/modules/projectiles/guns/ballistic/bows/_bow.dm#L52-L54 You can connect the dots. * Fixes bows not loosening their strings once fired --------- Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25703
Original PR: tgstation/tgstation#80317
About The Pull Request
Hello ancient sprite how u doin today :)
One de-souling later: Long Scream - Sound Effect - Youtube
Full and in-depth Changelist since there's a bit of random semi-related digging:
/datum/armor/warden_redand strip_delay from/obj/item/clothing/head/hats/warden/red- the armor values were the exact same as those of/datum/armor/hats_warden, which it'd inherit anyways alongside the strip_delayspacepolmask so it actually covers the nose on the side-statespacepoluniformpoliceuniform obj icon_statepolicehelmhat to match the new palettewarden_altsuit to match the new palette and have more consistent shading with the other warden jacketWhy It's Good For The Game
WOOP WOOP ITS DA SOUNDA DA POLICE (Screenshot is slightly outdated, missing the new buttons, but it's still mostly accurate)
And since the Warden reuses that hat, his jacket's been tweaked to match it's tweaks. Along with shading adjustments to have less 'banding' as somebody on discord put it (idk spriting terms I assume that I fixed it)
Changelog
🆑 OrionTheFox
image: the SpacePol bounty hunters have finally had a new run of Uniforms made, bringing them back to the forefront of enforcement fashion! Wardens will find their Police Jackets/Hats have been updated match SpacePol's new look as well.
fix: fixed the Mafia Warden having a hat that didn't match his jacket, and fixed SpacePol masks not covering the nose
/:cl: