[MIRROR] Fixed a runtime error with lobstrosity charge (also rust charge). #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rge). [MDB IGNORE] (#25716) * Fixed a runtime error with lobstrosity charge (also rust charge). (#80392) ## About The Pull Request Small premise: `basic_charge` can call `hit_target` for objects and not just mobs, unlike the parent type, also you usually call `try_hit_target` and not `hit_target` directly. That said, this PR fixes two small issues with a couple subtypes of the charge action. ## Why It's Good For The Game Runtimes bad. ## Changelog N/A * Fixed a runtime error with lobstrosity charge (also rust charge). --------- Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25716
Original PR: tgstation/tgstation#80392
About The Pull Request
Small premise:
basic_chargecan callhit_targetfor objects and not just mobs, unlike the parent type, also you usually calltry_hit_targetand nothit_targetdirectly. That said, this PR fixes two small issues with a couple subtypes of the charge action.Why It's Good For The Game
Runtimes bad.
Changelog
N/A