[MIRROR] Fixes a hard del in monkey AI #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a hard del in monkey AI (#80425) ## About The Pull Request  Fixes this hard del, caused by a del-on-death mob being qdeleted after being victim to the monkey's attack. When a mob gets qdeleted, they remove themselves from the blackboard. Monkey code was then adding it back immediately after, resulting in the hard del. Adds safeties to ensure that won't happen. ## Why It's Good For The Game Less annoying CI failures ## Changelog :cl: fix: monkeys will no longer cause other monkeys to get angry at the mobs they just poofed by attacking /:cl: * Fixes a hard del in monkey AI --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Dec 18, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 28, 2024
* fixes inability to create material airlocks (#81711) ## About The Pull Request Fixes tgstation/tgstation#81710 runtime due to parent proc not returning the airlock also added an update_appearance() ## Changelog :cl: fix: You can build material airlocks again /:cl: * fixes inability to create material airlocks --------- Co-authored-by: 13spacemen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25713
Original PR: tgstation/tgstation#80425
About The Pull Request
Fixes this hard del, caused by a del-on-death mob being qdeleted after being victim to the monkey's attack. When a mob gets qdeleted, they remove themselves from the blackboard.
Monkey code was then adding it back immediately after, resulting in the hard del. Adds safeties to ensure that won't happen.
Why It's Good For The Game
Less annoying CI failures
Changelog
🆑 vinylspiders
fix: monkeys will no longer cause other monkeys to get angry at the mobs they just poofed by attacking
/:cl: