[MIRROR] Plant Tank #1176
Merged
[MIRROR] Plant Tank #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* second attempt * some simple farm stuff * suggestions * Update modular_skyrat/modules/ashwalkers/code/buildings/planttank.dm * buffs gas production --------- Co-authored-by: GoldenAlpharex <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Dec 18, 2023
Iajret
pushed a commit
that referenced
this pull request
Mar 4, 2024
* NEW TRAIT ROLE: Veteran Advisor * Update jobs.dm * Update jobs.dm * Removes (probably) longer needed bandaid that should have been upstreamed This is not the right fix, and is causing a doubling of signals to fail CI. If it ends up being broken again it can be fixed properly. * There's more. --------- Co-authored-by: DrTuxedo <[email protected]> Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25328
About The Pull Request
This PR adds the plant tank-- a structure that when five sand is placed inside, allows the use of simple farming. That is not all that it can do. If you take grown food (produce) or worm fertilizer and place it inside the plant tank while it has a plant growing, it will slowly produce nitrogen and convert carbon dioxide to oxygen.
There are a few other changes beyond just adding the plant tank. Some changes include that the simple farm will set its glide size to whatever its parent atom is-- which means that if you plant stuff in minecarts or in the plant tank, the simple farm plant will actually move with the parent rather than doing a weird glitchy motion. Another thing that was added was that if the parent item (minecarts, plant tanks, etc. ) are deleted/removed, it will also remove the farm (which I don't know why I didn't add this earlier).
How This Contributes To The Skyrat Roleplay Experience
Realistically, plants do participate in the nitrogen cycle, as well as the oxygen cycle through photosynthesis. I think this is a nice way to allow another production of nitrogen and oxygen beyond the other methods (HFR for nitrogen and SM for oxygen).
Proof of Testing
Screenshots/Videos
Changelog
🆑 jjpark-kb
add: added the plant tank-- allows simple farm growing and production of nitrogen and oxygen
fix: simple farms will now destroy themselves if their parent atom is destroyed
/:cl: