Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] LOOC'ing while in crit..? Or while unconscious..? You got it! #1174

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#25506

About The Pull Request

This PR should allow you to LOOC while in soft-crit/hard-crit/unconscious. Yeah.

How This Contributes To The Skyrat Roleplay Experience

Imagine this:
There's a full skeleton pirate crew, and there's a HoS

The HoS has been put into softcrit and is about to be brought onto the ship, and be unrevivable for a very long time probably, like it usually happens

The HoS does not want to be practically RR'd, since they play Skyrat like once a week, and that's fully okay.

The HoS cannot LOOC while in crit, and now has only 4 real options:

  • Ahelp the pirate crew
  • Salt on Discord about how they got forgotten
  • Whisper something LRP to try and tell them
  • Salt in DChat about how "BRO I'VE BEEN DEAD FOR 2 HOURS HOW DID THEY NOT NOTICE"

If LOOC was enabled while in crit though..

  • LOOC "pls no rr"
    and that'd most likely be the end of it. Generally, I feel like there are many more benefits to enabling crit LOOC than negatives. By enabling it, it also allows people to consent to certain things while in crit, such as Kidnapping, if the contractor happened to accidentally bomb someone to death, or to "tell your knifeplay enthusiast Yes - Dom surgeon which specific organs you really hope are missing when you wake up from the haze of masochistic pain." - Friendly Player

Additionally, I feel like the positive effects of such change will be way more apparent once the Opt-In system takes place.

Proof of Testing (UPDATED!!!!)

Screenshots/Videos

image

image
image
image
image
image
image

Changelog

🆑 KannaLisvern
qol: You can now LOOC while in crit/unconscious.
/:cl:

* removes the part that makes crit looc exist

* makes it so you cant LOOC while dead
@ReezeBL ReezeBL merged commit 9f0b7e2 into master Dec 18, 2023
23 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-25506 branch December 18, 2023 14:23
AnywayFarus added a commit that referenced this pull request Dec 18, 2023
Iajret pushed a commit that referenced this pull request Feb 27, 2024
…for real this time) (#1174)

* [NO GBP] Fixes spurious CI failures from museum ash spawns (for real this time) (#81690)

## About The Pull Request

I saw this runtime again despite thinking I fixed it and then realized I
needed to be calling `ispath()` since we are not working with an
instantiated object with these lists. Oops

## Why It's Good For The Game

Working code is good

## Changelog

Nothing player facing

* [NO GBP] Fixes spurious CI failures from museum ash spawns (for real this time)

---------

Co-authored-by: Bloop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants