[MIRROR] I See Clearly Now: Laser pointer balance adjustments #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Laser pointer fixes: remove felinid forced movement, chat notifications, add limited laser pointer type * Comment formatting fixes Co-authored-by: Bloop <[email protected]> * Trailing formatting fix Co-authored-by: Bloop <[email protected]> * Modularise * Make GCF vendor sell limited laserpointers * Apply suggestions from code review --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Dec 18, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 27, 2024
…mmand status (#1173) * Make lobby manifest use trim instead of rank to determine command status * Update manifest.dm * Update CrewManifest.jsx * No longer an edit --------- Co-authored-by: _0Steven <[email protected]> Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25588
About The Pull Request
Since laser pointers are loadout-available as of Skyrat-SS13/Skyrat-tg#25532, this PR does a little bit of balancejakking on them to make the prospect not pure misery for cyborgs and felinid players. It does the following:
visible_messagesignalling to show nearby players who is pointing a laser pointer, and at what. Includesspan_dangercolouring if the person is trying to do something hostile with said action.How This Contributes To The Skyrat Roleplay Experience
This should help make a sudden glut of laser pointers via loadout availability not quite as miserable as they could've been. The camera EMP thing is still going to make AI players pretty miserable, as is the ranged stun/flash on cyborgs, but we can address that as we go, I guess.
Proof of Testing
Screenshots/Videos
dreamseeker_lSlCb2swo1.mp4
Changelog
🆑 yooriss
fix: Laser pointers now show appropriate messaging to nearby players when someone is using them for both benign and hostile actions.
fix: Due to budget cuts and petitioning from protesting silicons, the FTU has replaced all full-power laser pointers available in crew loadouts and Good Clean Fun vendors with limited promotional variants that can't have their diodes repaired or upgraded on the field. Joint litigation by the NT research and service departments has allowed the RD and lawyers to keep their original ones, however.
fix: Extensive lobbying by the Felinid Rights Association has forced the FTU to replace all laser pointer diodes with special low 'radiationyan' variants that no longer trigger felinids to compulsively leap. They're still super distracting though...
/:cl: