[MIRROR] Fixes Runtime When Thanking Non-Existent Clown #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(#25666) * Fixes Runtime When Thanking Non-Existent Clown (#80337) ## About The Pull Request Currently, attempting to thank the driver of a clown car when none exists causes a runtime. This is because while there is logic to ensure we don't attempt to thank a driver if there is none, said logic only checks the result of a pick() called on the list of drivers, which will runtime if the list is empty. This PR fixes the error by checking if the the driver list is empty first, then using pick() solely for choosing a driver to thank. ## Why It's Good For The Game While this isn't a very common runtime in normal gameplay, it is a bug and should be fixed regardless. ## Changelog :cl: fix: Fixed runtime regarding thanking non-existent clown car drivers /:cl: * Fixes Runtime When Thanking Non-Existent Clown --------- Co-authored-by: IndieanaJones <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Dec 17, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Birdshot Chapel Fixes & Improvements (#81642) ## About The Pull Request Slightly remaps Birdshot's Monastery Garden, moves the altar, and changes the area so Sparring Sect chaplains have a place to fight. Fixes: #81614  ## Why It's Good For The Game The Chaplain didn't really have a place to preach before, and they also had nowhere to spar! This converts the garden into a more useable space. ## Changelog :cl: qol: The chapel has been slightly overhauled on Birdshot, with the chaplain now having a place to preach sermons. fix: Sparring chaplains are now able to operate on Birdshot! /:cl: * Birdshot Chapel Fixes & Improvements --------- Co-authored-by: Cheshify <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25666
Original PR: tgstation/tgstation#80337
About The Pull Request
Currently, attempting to thank the driver of a clown car when none exists causes a runtime. This is because while there is logic to ensure we don't attempt to thank a driver if there is none, said logic only checks the result of a pick() called on the list of drivers, which will runtime if the list is empty. This PR fixes the error by checking if the the driver list is empty first, then using pick() solely for choosing a driver to thank.
Why It's Good For The Game
While this isn't a very common runtime in normal gameplay, it is a bug and should be fixed regardless.
Changelog
🆑 IndieanaJones
fix: Fixed runtime regarding thanking non-existent clown car drivers
/:cl: