Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barsigns Competition #1155

Merged
merged 5 commits into from Dec 17, 2023
Merged

Barsigns Competition #1155

merged 5 commits into from Dec 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2023

Победитель 1:
dreamseeker_ZAjuqkVi2l.mp4
Победитель 2:
dreamseeker_SeoTwpQbGg.mp4

Changelog

🆑
add: Barsigns of discord competition now in game!
/:cl:

@ghost
Copy link
Author

ghost commented Dec 16, 2023

Возможно юнит-тест не пройдёт и я выкачу дополнительную оверрайдину.

@ghost
Copy link
Author

ghost commented Dec 16, 2023

Угусь. Сейчас подумаю как исправить.

code/modules/unit_tests/barsigns.dm Outdated Show resolved Hide resolved
tff_modular/modules/barsigns/code/barsigns.dm Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Dec 17, 2023

Дождусь проверки. Не должно по идее сломать юнит тесты.

@ghost ghost requested a review from Iajret December 17, 2023 18:53
@Iajret Iajret merged commit 836a096 into Fluffy-Frontier:master Dec 17, 2023
22 checks passed
AnywayFarus added a commit that referenced this pull request Dec 17, 2023
Iajret pushed a commit that referenced this pull request Feb 26, 2024
* General maintenance for frames (#81473)

## About The Pull Request
Builds upon the changes in
tgstation/tgstation#81477

**1. Qol**
- Adds detailed examines & screentips for building & deconstructing both
machine & computer frames
- Adding a circuitboard from a rped to a computer frame will
automatically screw it in place like before

**2. Code Improvements**
- Merged procs like `update_path_names()` , `get_requested_amt()` etc
into their required places to reduce proc calls
- Autodocs procs like `add_cable()`, `add_glass()` etc. makes them
private
- Moved code for machine frame into its own file

* General maintenance for frames

---------

Co-authored-by: SyncIt21 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants