Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Input component in tsx #1151

Merged
merged 3 commits into from
Dec 18, 2023
Merged

[MIRROR] Input component in tsx #1151

merged 3 commits into from
Dec 18, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25654
Original PR: tgstation/tgstation#80340

About The Pull Request

Converts Input to a typescript functional component. Clears up some usages of onInput => onChange.

Why It's Good For The Game

More typescript components + better dev exp

Changelog

N/A nothing player facing

* Input component in tsx (#80340)

Converts Input to a typescript functional component. Clears up some
usages of onInput => onChange.
More typescript components + better dev exp
N/A nothing player facing

* Input component in tsx

---------

Co-authored-by: Jeremiah <[email protected]>
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror labels Dec 16, 2023
@Iajret Iajret merged commit 14eb980 into master Dec 18, 2023
22 checks passed
@Iajret Iajret deleted the upstream-mirror-25654 branch December 18, 2023 17:38
Iajret pushed a commit that referenced this pull request Feb 26, 2024
…ge log (#1151)

* Fixes paddy claw missing sanity checks / action checks / usage log (#81596)

## About The Pull Request

Paddy mech claw didn't
- Call `action_checks`
- istype the right type 
- call parent (no signal, no log) 

This fixes that. 

## Changelog

:cl: Melbert
fix: The Paddy's Claw should be properly unusable in situations which it
should be properly unusable.
/:cl:

* Fixes paddy claw missing sanity checks / action checks / usage log

---------

Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants