[MIRROR] Paxilmaniac makes the best skyrat pr ever | Deletes germany (every single weapon from the gunsgalore module) #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngle weapon from the gunsgalore module) (#25388) * cant wait for all the compile this will make * compile errors pt 1 * solfed outfit gun fixing * fixes black mesa, again * i missed two m16s --------- Co-authored-by: Bloop <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-25388
AnywayFarus
added a commit
that referenced
this pull request
Dec 17, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 26, 2024
* Minor newscaster UI fix (#81638) ## About The Pull Request Currently newscasters note "No wanted issue posted. Have a secure day." regardless of whether there's an active wanted issue posted or not. Looking into the code, `Newscaster.jsx` does actually detail an alternate message for when there _is_ an active wanted issue. It's just only active when `wanted.active` holds true, while I believe the `active` it's trying to access cannot be accessed without using `wanted.map(...)`. Making it use `wanted.map(...)` solves this. <details> <summary>Image</summary>  </details> ## Why It's Good For The Game Fixes #81600. ## Changelog :cl: fix: Newscasters no longer say "No wanted issue posted. Have a secure day." when there is, in fact, an active wanted issue currently posted. /:cl: * Minor newscaster UI fix --------- Co-authored-by: _0Steven <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25388
About The Pull Request
As the title says simply, I am deleting every single one of the guns from the gunsgalore module.
Players will see literally zero effects of this however, because as it currently stands, these guns show up literally nowhere except the black mesa gateway we don't run.
How This Contributes To The Skyrat Roleplay Experience
Every single one of these are unused anywhere that matters, and anywhere they do "matter", they can be replaced with the now existing weapons I've made that aren't just guns from world war two. Every single one of these is an insane weapon in their own ways, too, and unknowning admins keep spawning them for events or whatever and watching as someone wipes the entire sec team with the poopenfarten 42 or whatever it is.
Proof of Testing
Er I mean look its just deleting a bunch of stuff, I could show it compiling or the guns not being in the menu or something if you REALLY wanted.
Changelog
🆑 Paxilmaniac
del: Every gun from the gunsgalore module has been deleted, long live the king
/:cl: