[MIRROR] Converts button to typescript #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Converts button to typescript (#80194) ## About The Pull Request Converts one of our most used components into TypeScript. Fixes an issue with it where ellipses were not working. This is tricky though. Some people are using ellipsis prop but passing in full nodes. Tgui is not smart enough to handle this - it only works on strings! You will need to custom write the style if you're trying this. I've wrote up documentation in the component and a restrictive type that will warn anyone trying to concatenate a node. ## Why It's Good For The Game Closes #78220 ## Changelog N/A nothing player facing * Converts button to typescript --------- Co-authored-by: Jeremiah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25625
Original PR: tgstation/tgstation#80194
About The Pull Request
Converts one of our most used components into TypeScript. Fixes an issue with it where ellipses were not working.
This is tricky though. Some people are using ellipsis prop but passing in full nodes. Tgui is not smart enough to handle this - it only works on strings! You will need to custom write the style if you're trying this. I've wrote up documentation in the component and a restrictive type that will warn anyone trying to concatenate a node.
Why It's Good For The Game
Closes #78220
Changelog
N/A nothing player facing